[PATCH 0/3] qapi: Random small fixes

[PATCH 0/3] qapi: Random small fixes

[Andrea Bolognani]

Andrea Bolognani (3):
  docs: qapi: Remove outdated reference to simple unions
  qapi: Fix documentation for query-xen-replication-status
  qapi: Fix typo

 docs/devel/qapi-code-gen.rst | 4 ++--
 qapi/migration.json          | 2 +-
 qapi/sockets.json            | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.35.1

[PATCH 1/3] docs: qapi: Remove outdated reference to simple unions

[Andrea Bolognani]

Commit 4e99f4b12c0e dropped simple unions and updated most
documentation accordingly, but in one case we still claim that
there are "two flavors of unions".

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 docs/devel/qapi-code-gen.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index 246709ede8..7b968433a6 100644
--- a/docs/devel/qapi-code-gen.rst
+++ b/docs/devel/qapi-code-gen.rst
@@ -41,8 +41,8 @@ used internally.
 
 There are several kinds of types: simple types (a number of built-in
 types, such as ``int`` and ``str``; as well as enumerations), arrays,
-complex types (structs and two flavors of unions), and alternate types
-(a choice between other types).
+complex types (structs and unions), and alternate types (a choice
+between other types).
 
 
 Schema syntax
-- 
2.35.1

[PATCH 2/3] qapi: Fix documentation for query-xen-replication-status

[Andrea Bolognani]

The correct return type is ReplicationStatus, not
ReplicationResult.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 qapi/migration.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index 27d7b28158..409eb086a2 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1619,7 +1619,7 @@
 #
 # Query replication status while the vm is running.
 #
-# Returns: A @ReplicationResult object showing the status.
+# Returns: A @ReplicationStatus object showing the status.
 #
 # Example:
 #
-- 
2.35.1

Re: [PATCH 2/3] qapi: Fix documentation for query-xen-replication-status

[Dr. David Alan Gilbert]

* Andrea Bolognani (abologna@redhat.com) wrote:
> The correct return type is ReplicationStatus, not
> ReplicationResult.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Hmm yes I think that's right.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  qapi/migration.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 27d7b28158..409eb086a2 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1619,7 +1619,7 @@
>  #
>  # Query replication status while the vm is running.
>  #
> -# Returns: A @ReplicationResult object showing the status.
> +# Returns: A @ReplicationStatus object showing the status.
>  #
>  # Example:
>  #
> -- 
> 2.35.1
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

[PATCH 3/3] qapi: Fix typo

[Andrea Bolognani]

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 qapi/sockets.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/sockets.json b/qapi/sockets.json
index 5773d9fcc4..fccc38584b 100644
--- a/qapi/sockets.json
+++ b/qapi/sockets.json
@@ -149,7 +149,7 @@
 #
 # Note: This type is deprecated in favor of SocketAddress.  The
 #       difference between SocketAddressLegacy and SocketAddress is that the
-#       latter is has fewer {} on the wire.
+#       latter has fewer {} on the wire.
 #
 # Since: 1.3
 ##
-- 
2.35.1

Re: [PATCH 0/3] qapi: Random small fixes

[Markus Armbruster]

Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Queued, thanks!