From: Ian Cowan <ian@linux.cowan.aero>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Staging: fbtft: Fix style problem in header
Date: Wed, 20 Apr 2022 13:20:14 -0400 [thread overview]
Message-ID: <YmBAzpHz2qhb69Ux@fedora> (raw)
In-Reply-To: <e4f56999-cf58-abff-edf5-ae11d024012b@redhat.com>
On Wed, Apr 20, 2022 at 05:47:49PM +0200, Javier Martinez Canillas wrote:
> On 4/20/22 16:36, Uwe Kleine-König wrote:
> You are just changing a header file though, did you also enable one of the
> fbtft drivers as a module to see if those build? But as said, by looking at
> the code it seems that should build correctly.
Not loading the driver was the issue. Thanks for helping me get it fixed!
---
Ian Cowan
WARNING: multiple messages have this Message-ID (diff)
From: Ian Cowan <ian@linux.cowan.aero>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] Staging: fbtft: Fix style problem in header
Date: Wed, 20 Apr 2022 13:20:14 -0400 [thread overview]
Message-ID: <YmBAzpHz2qhb69Ux@fedora> (raw)
In-Reply-To: <e4f56999-cf58-abff-edf5-ae11d024012b@redhat.com>
On Wed, Apr 20, 2022 at 05:47:49PM +0200, Javier Martinez Canillas wrote:
> On 4/20/22 16:36, Uwe Kleine-König wrote:
> You are just changing a header file though, did you also enable one of the
> fbtft drivers as a module to see if those build? But as said, by looking at
> the code it seems that should build correctly.
Not loading the driver was the issue. Thanks for helping me get it fixed!
---
Ian Cowan
next prev parent reply other threads:[~2022-04-20 17:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 19:21 [PATCH] Staging: fbtft: Fix style problem in header Ian Cowan
2022-04-19 19:21 ` Ian Cowan
2022-04-20 1:32 ` kernel test robot
2022-04-20 1:32 ` kernel test robot
2022-04-20 6:47 ` Uwe Kleine-König
2022-04-20 6:47 ` Uwe Kleine-König
2022-04-20 13:57 ` Ian Cowan
2022-04-20 13:57 ` Ian Cowan
2022-04-20 14:36 ` Uwe Kleine-König
2022-04-20 14:36 ` Uwe Kleine-König
2022-04-20 15:47 ` Javier Martinez Canillas
2022-04-20 17:19 ` Javier Martinez Canillas
2022-04-20 17:20 ` Ian Cowan [this message]
2022-04-20 17:20 ` Ian Cowan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmBAzpHz2qhb69Ux@fedora \
--to=ian@linux.cowan.aero \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.