Re: [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc.c: Remove PC8+ dependency from DC9.

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Apr 20, 2022 at 03:27:19PM -0400, Srivatsa, Anusha wrote:
> 
> 
> > -----Original Message-----
> > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > Sent: Wednesday, April 20, 2022 12:09 PM
> > To: igt-dev@lists.freedesktop.org; Srivatsa, Anusha
> > <anusha.srivatsa@intel.com>
> > Cc: Gupta, Anshuman <anshuman.gupta@intel.com>; Deak, Imre
> > <imre.deak@intel.com>
> > Subject: Re: [PATCH i-g-t] tests/i915/i915_pm_dc.c: Remove PC8+
> > dependency from DC9.
> > 
> > On Wed, 2022-04-20 at 12:07 -0700, Srivatsa, Anusha wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > > > Sent: Wednesday, April 20, 2022 11:46 AM
> > > > To: igt-dev@lists.freedesktop.org
> > > > Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Deak, Imre
> > > > <imre.deak@intel.com>; Gupta, Anshuman
> > <anshuman.gupta@intel.com>;
> > > > Srivatsa, Anusha <anusha.srivatsa@intel.com>
> > > > Subject: [PATCH i-g-t] tests/i915/i915_pm_dc.c: Remove PC8+
> > > > dependency from DC9.
> > > >
> > > > Different from DC6, DC9 does not depend on the BIOS/PCU to execute
> > > > save and restore or any other sequence when going to PC9/PC10.
> > > >
> > > > DC9 actually depends on D3 and PCODE simply remove power if SW
> > > > allowed.
> > >
> > > Is this the case for both igfx and dgfx?
> > 
> > yes
> > 
> When the check was introduced- for ICL, wasn’t this the requirement though? How come we have not had issues on ICL+ platforms till now if the check was wrong. 

The foils I'm checking is for gen9+. I have fwded it to you couple weeks ago.

DC9 never had any dependency on Package-C states, but only on D3.
Even on BXT.

I believe this addition here was accidental when adding the checks for DC6.

> 
> Anusha
> > >
> > > Anusha
> > >
> > > > Cc: Imre Deak <imre.deak@intel.com>
> > > > Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> > > > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > ---
> > > >  tests/i915/i915_pm_dc.c | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index
> > > > 2c2c5086..9a22246c 100644
> > > > --- a/tests/i915/i915_pm_dc.c
> > > > +++ b/tests/i915/i915_pm_dc.c
> > > > @@ -531,8 +531,6 @@ int main(int argc, char *argv[])
> > > >
> > > >         igt_describe("This test validates display engine entry to
> > > > DC9 state");
> > > >         igt_subtest("dc9-dpms") {
> > > > -
> > > >         igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_
> > > > fd),
> > > > -                               "PC8+ residencies not supported\n");
> > > >                 test_dc9_dpms(&data);
> > > >         }
> > > >
> > > > --
> > > > 2.34.1
> > >
>