All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
Cc: catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, fenghua.yu@intel.com,
	reinette.chatre@intel.com
Subject: Re: [PATCH v3 1/9] drivers: base: Add hardware prefetch control core driver
Date: Thu, 21 Apr 2022 08:18:57 +0200	[thread overview]
Message-ID: <YmD3UX6aTvUXlYF5@kroah.com> (raw)
In-Reply-To: <20220420030223.689259-2-tarumizu.kohei@fujitsu.com>

On Wed, Apr 20, 2022 at 12:02:15PM +0900, Kohei Tarumizu wrote:
> This driver adds the register/unregister function to create the
> "prefetch_control" directory and some attribute files. Attributes are
> only present if the particular cache implements the relevant
> prefetcher controls
> 
> If the architecture has control of the CPU's hardware prefetcher
> behavior, use this function to create sysfs. When registering, it is
> necessary to provide what type of hardware prefetcher is supported
> and how to read/write to the register.
> 
> Following patches add support for A64FX and x86.
> 
> Signed-off-by: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
> ---
>  drivers/base/pfctl.c  | 458 ++++++++++++++++++++++++++++++++++++++++++
>  include/linux/pfctl.h |  49 +++++
>  2 files changed, 507 insertions(+)
>  create mode 100644 drivers/base/pfctl.c
>  create mode 100644 include/linux/pfctl.h

Thanks to Thomas for pointing this change out to me.

Why did you not use get_maintainer.pl on your patch?  You are adding
files here that you want _me_ to maintain for the next 25+ years, yet
not asking for my review?  That's not nice, and for that reason alone I
would not accept this change.

Also, this is very hardware-specific, which is not a good thing for code
in drivers/base/  See the mess we have in the topology driver core code
for examples of that mess :(

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
Cc: catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, fenghua.yu@intel.com,
	reinette.chatre@intel.com
Subject: Re: [PATCH v3 1/9] drivers: base: Add hardware prefetch control core driver
Date: Thu, 21 Apr 2022 08:18:57 +0200	[thread overview]
Message-ID: <YmD3UX6aTvUXlYF5@kroah.com> (raw)
In-Reply-To: <20220420030223.689259-2-tarumizu.kohei@fujitsu.com>

On Wed, Apr 20, 2022 at 12:02:15PM +0900, Kohei Tarumizu wrote:
> This driver adds the register/unregister function to create the
> "prefetch_control" directory and some attribute files. Attributes are
> only present if the particular cache implements the relevant
> prefetcher controls
> 
> If the architecture has control of the CPU's hardware prefetcher
> behavior, use this function to create sysfs. When registering, it is
> necessary to provide what type of hardware prefetcher is supported
> and how to read/write to the register.
> 
> Following patches add support for A64FX and x86.
> 
> Signed-off-by: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
> ---
>  drivers/base/pfctl.c  | 458 ++++++++++++++++++++++++++++++++++++++++++
>  include/linux/pfctl.h |  49 +++++
>  2 files changed, 507 insertions(+)
>  create mode 100644 drivers/base/pfctl.c
>  create mode 100644 include/linux/pfctl.h

Thanks to Thomas for pointing this change out to me.

Why did you not use get_maintainer.pl on your patch?  You are adding
files here that you want _me_ to maintain for the next 25+ years, yet
not asking for my review?  That's not nice, and for that reason alone I
would not accept this change.

Also, this is very hardware-specific, which is not a good thing for code
in drivers/base/  See the mess we have in the topology driver core code
for examples of that mess :(

greg k-h

  parent reply	other threads:[~2022-04-21  6:20 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  3:02 [PATCH v3 0/9] Add hardware prefetch control driver for A64FX and x86 Kohei Tarumizu
2022-04-20  3:02 ` Kohei Tarumizu
2022-04-20  3:02 ` [PATCH v3 1/9] drivers: base: Add hardware prefetch control core driver Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20 21:40   ` Thomas Gleixner
2022-04-20 21:40     ` Thomas Gleixner
2022-04-22 12:10     ` tarumizu.kohei
2022-04-22 12:10       ` tarumizu.kohei
2022-04-21  6:18   ` Greg KH [this message]
2022-04-21  6:18     ` Greg KH
2022-04-22 12:30     ` tarumizu.kohei
2022-04-22 12:30       ` tarumizu.kohei
2022-04-20  3:02 ` [PATCH v3 2/9] drivers: base: Add Kconfig/Makefile to build " Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20  3:02 ` [PATCH v3 3/9] soc: fujitsu: Add hardware prefetch control support for A64FX Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20  3:02 ` [PATCH v3 4/9] soc: fujitsu: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20 22:14   ` Thomas Gleixner
2022-04-20 22:14     ` Thomas Gleixner
2022-04-20  3:02 ` [PATCH v3 5/9] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20  3:02 ` [PATCH v3 6/9] x86: resctrl: pseudo_lock: Fix to restore to original value when re-enabling hardware prefetch register Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20 20:56   ` Dave Hansen
2022-04-20 20:56     ` Dave Hansen
2022-04-22 12:01     ` tarumizu.kohei
2022-04-22 12:01       ` tarumizu.kohei
2022-04-25 23:17   ` Reinette Chatre
2022-04-25 23:17     ` Reinette Chatre
2022-04-27  2:51     ` tarumizu.kohei
2022-04-27  2:51       ` tarumizu.kohei
2022-04-20  3:02 ` [PATCH v3 7/9] x86: Add hardware prefetch control support for x86 Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20 22:27   ` Thomas Gleixner
2022-04-20 22:27     ` Thomas Gleixner
2022-04-22 12:16     ` tarumizu.kohei
2022-04-22 12:16       ` tarumizu.kohei
2022-04-20  3:02 ` [PATCH v3 8/9] x86: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu
2022-04-20  3:02 ` [PATCH v3 9/9] docs: ABI: Add sysfs documentation interface of " Kohei Tarumizu
2022-04-20  3:02   ` Kohei Tarumizu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmD3UX6aTvUXlYF5@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tarumizu.kohei@fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.