All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Sean Anderson <sean.anderson@seco.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Michael Walle <michael@walle.cc>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Li Yang <leoyang.li@nxp.com>,
	linux-kernel@vger.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH 3/8] dt-bindings: nvmem: sfp: Add TA_PROG_SFP supply
Date: Thu, 21 Apr 2022 23:59:28 +0200	[thread overview]
Message-ID: <YmHTwPsZ2QNoFmAF@lunn.ch> (raw)
In-Reply-To: <20220421175657.1259024-4-sean.anderson@seco.com>

On Thu, Apr 21, 2022 at 01:56:52PM -0400, Sean Anderson wrote:
> The TA_PROG_SFP supply must be enabled to program the fuses, and
> disabled to read the fuses (such as at power-on-reset). On many boards,
> this supply is controlled by a jumper. The user must manually insert or
> remove it at the appropriate time in the programming process. However,
> on other boards this supply is controlled by and FPGA or a GPIO. In
> these cases, the driver can automatically enabled and disable it as
> necessary.
> 
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
> 
>  .../devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> index 54086f50157d..e7d1232fcd41 100644
> --- a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> @@ -32,6 +32,11 @@ properties:
>    clock-names:
>      const: sfp
>  
> +  ta-prog-sfp-supply:
> +    description:
> +      The TA_PROG_SFP supply. It will be enabled for programming and disabled
> +      for reading.
> +

Doesn't there need to be some indication what this is? Is it a GPIO,
or maybe a regulator?

   Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Sean Anderson <sean.anderson@seco.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Michael Walle <michael@walle.cc>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Li Yang <leoyang.li@nxp.com>,
	linux-kernel@vger.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH 3/8] dt-bindings: nvmem: sfp: Add TA_PROG_SFP supply
Date: Thu, 21 Apr 2022 23:59:28 +0200	[thread overview]
Message-ID: <YmHTwPsZ2QNoFmAF@lunn.ch> (raw)
In-Reply-To: <20220421175657.1259024-4-sean.anderson@seco.com>

On Thu, Apr 21, 2022 at 01:56:52PM -0400, Sean Anderson wrote:
> The TA_PROG_SFP supply must be enabled to program the fuses, and
> disabled to read the fuses (such as at power-on-reset). On many boards,
> this supply is controlled by a jumper. The user must manually insert or
> remove it at the appropriate time in the programming process. However,
> on other boards this supply is controlled by and FPGA or a GPIO. In
> these cases, the driver can automatically enabled and disable it as
> necessary.
> 
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
> 
>  .../devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> index 54086f50157d..e7d1232fcd41 100644
> --- a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> @@ -32,6 +32,11 @@ properties:
>    clock-names:
>      const: sfp
>  
> +  ta-prog-sfp-supply:
> +    description:
> +      The TA_PROG_SFP supply. It will be enabled for programming and disabled
> +      for reading.
> +

Doesn't there need to be some indication what this is? Is it a GPIO,
or maybe a regulator?

   Andrew

  reply	other threads:[~2022-04-21 22:00 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 17:56 [PATCH 0/8] nvmem: sfp: binding updates and additions Sean Anderson
2022-04-21 17:56 ` Sean Anderson
2022-04-21 17:56 ` [PATCH 1/8] dt-bindings: nvmem: sfp: Fix typo Sean Anderson
2022-04-21 17:56   ` Sean Anderson
2022-04-21 18:03   ` Michael Walle
2022-04-21 18:03     ` Michael Walle
2022-04-21 21:55   ` Andrew Lunn
2022-04-21 21:55     ` Andrew Lunn
2022-04-21 17:56 ` [PATCH 2/8] dt-bindings: nvmem: sfp: Add clock properties Sean Anderson
2022-04-21 17:56   ` Sean Anderson
2022-04-21 18:12   ` Michael Walle
2022-04-21 18:12     ` Michael Walle
2022-04-22 21:27     ` Rob Herring
2022-04-22 21:27       ` Rob Herring
2022-04-22 13:36   ` Rob Herring
2022-04-22 13:36     ` Rob Herring
2022-04-22 14:33     ` Sean Anderson
2022-04-22 14:33       ` Sean Anderson
2022-04-21 17:56 ` [PATCH 3/8] dt-bindings: nvmem: sfp: Add TA_PROG_SFP supply Sean Anderson
2022-04-21 17:56   ` Sean Anderson
2022-04-21 21:59   ` Andrew Lunn [this message]
2022-04-21 21:59     ` Andrew Lunn
2022-04-21 22:06     ` Sean Anderson
2022-04-21 22:06       ` Sean Anderson
2022-04-21 23:02       ` Andrew Lunn
2022-04-21 23:02         ` Andrew Lunn
2022-04-21 17:56 ` [PATCH 4/8] dt-bindings: nvmem: sfp: Add compatible binding for TA 2.1 SFPs Sean Anderson
2022-04-21 17:56   ` Sean Anderson
2022-04-21 18:18   ` Michael Walle
2022-04-21 18:18     ` Michael Walle
2022-04-21 18:47     ` Sean Anderson
2022-04-21 18:47       ` Sean Anderson
2022-04-21 17:56 ` [PATCH 5/8] arm64: dts: ls1028a: Update SFP binding to include clock Sean Anderson
2022-04-21 17:56   ` Sean Anderson
2022-04-21 18:44   ` Michael Walle
2022-04-21 18:44     ` Michael Walle
2022-04-21 17:56 ` [PATCH 6/8] ARM: dts: layerscape: Add SFP binding for TA 2.1 devices Sean Anderson
2022-04-21 17:56   ` Sean Anderson
2022-04-21 17:56 ` [PATCH 7/8] ARM: dts: Add SFP binding for TA 3.0 devices Sean Anderson
2022-04-21 17:56   ` Sean Anderson
2022-04-21 17:56 ` [PATCH 8/8] nvmem: sfp: Add support for TA 2.1 devices Sean Anderson
2022-04-21 17:56   ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmHTwPsZ2QNoFmAF@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    --cc=sean.anderson@seco.com \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.