All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Chen-Yu Tsai <wenst@chromium.org>,
	Ryder Lee <ryder.lee@kernel.org>, Hui Liu <hui.liu@mediatek.com>,
	Irui Wang <irui.wang@mediatek.com>
Subject: Re: [PATCH 4/4] dt-bindings: media: mtk-vcodec: Add encoder power domain property
Date: Mon, 25 Apr 2022 11:37:28 -0500	[thread overview]
Message-ID: <YmbOSHlTLRVzZOtr@robh.at.kernel.org> (raw)
In-Reply-To: <20220421035111.7267-5-allen-kh.cheng@mediatek.com>

On Thu, Apr 21, 2022 at 11:51:11AM +0800, Allen-KH Cheng wrote:
> From: Irui Wang <irui.wang@mediatek.com>
> 
> Add encoder power domain property
> 
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index e7b65a91c92c..de2df6c6352c 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>  
>    assigned-clock-parents: true
>  
> +  power-domains:
> +    maxItems: 1
> +
>    iommus:
>      minItems: 1
>      maxItems: 32
> @@ -74,6 +77,7 @@ required:
>    - iommus
>    - assigned-clocks
>    - assigned-clock-parents
> +  - power-domains

New properties can't be required as that's an ABI change unless there is 
some explanation why it is okay/necessary.

Rob

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Chen-Yu Tsai <wenst@chromium.org>,
	Ryder Lee <ryder.lee@kernel.org>, Hui Liu <hui.liu@mediatek.com>,
	Irui Wang <irui.wang@mediatek.com>
Subject: Re: [PATCH 4/4] dt-bindings: media: mtk-vcodec: Add encoder power domain property
Date: Mon, 25 Apr 2022 11:37:28 -0500	[thread overview]
Message-ID: <YmbOSHlTLRVzZOtr@robh.at.kernel.org> (raw)
In-Reply-To: <20220421035111.7267-5-allen-kh.cheng@mediatek.com>

On Thu, Apr 21, 2022 at 11:51:11AM +0800, Allen-KH Cheng wrote:
> From: Irui Wang <irui.wang@mediatek.com>
> 
> Add encoder power domain property
> 
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index e7b65a91c92c..de2df6c6352c 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>  
>    assigned-clock-parents: true
>  
> +  power-domains:
> +    maxItems: 1
> +
>    iommus:
>      minItems: 1
>      maxItems: 32
> @@ -74,6 +77,7 @@ required:
>    - iommus
>    - assigned-clocks
>    - assigned-clock-parents
> +  - power-domains

New properties can't be required as that's an ABI change unless there is 
some explanation why it is okay/necessary.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Chen-Yu Tsai <wenst@chromium.org>,
	Ryder Lee <ryder.lee@kernel.org>, Hui Liu <hui.liu@mediatek.com>,
	Irui Wang <irui.wang@mediatek.com>
Subject: Re: [PATCH 4/4] dt-bindings: media: mtk-vcodec: Add encoder power domain property
Date: Mon, 25 Apr 2022 11:37:28 -0500	[thread overview]
Message-ID: <YmbOSHlTLRVzZOtr@robh.at.kernel.org> (raw)
In-Reply-To: <20220421035111.7267-5-allen-kh.cheng@mediatek.com>

On Thu, Apr 21, 2022 at 11:51:11AM +0800, Allen-KH Cheng wrote:
> From: Irui Wang <irui.wang@mediatek.com>
> 
> Add encoder power domain property
> 
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index e7b65a91c92c..de2df6c6352c 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>  
>    assigned-clock-parents: true
>  
> +  power-domains:
> +    maxItems: 1
> +
>    iommus:
>      minItems: 1
>      maxItems: 32
> @@ -74,6 +77,7 @@ required:
>    - iommus
>    - assigned-clocks
>    - assigned-clock-parents
> +  - power-domains

New properties can't be required as that's an ABI change unless there is 
some explanation why it is okay/necessary.

Rob

  parent reply	other threads:[~2022-04-25 16:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21  3:51 [PATCH 0/4] Correct power domain for encoder Allen-KH Cheng
2022-04-21  3:51 ` Allen-KH Cheng
2022-04-21  3:51 ` Allen-KH Cheng
2022-04-21  3:51 ` [PATCH 1/4] arm: dts: mediatek: Get rid of mediatek, larb for MM nodes Allen-KH Cheng
2022-04-21  3:51   ` [PATCH 1/4] arm: dts: mediatek: Get rid of mediatek,larb " Allen-KH Cheng
2022-04-21  3:51   ` [PATCH 1/4] arm: dts: mediatek: Get rid of mediatek, larb " Allen-KH Cheng
2022-04-21  3:51 ` [PATCH 2/4] arm64: " Allen-KH Cheng
2022-04-21  3:51   ` [PATCH 2/4] arm64: dts: mediatek: Get rid of mediatek,larb " Allen-KH Cheng
2022-04-21  3:51   ` [PATCH 2/4] arm64: dts: mediatek: Get rid of mediatek, larb " Allen-KH Cheng
2022-04-21  3:51 ` [PATCH 3/4] arm64: dts: mediatek: mt8173: Add power domain to encoder nodes Allen-KH Cheng
2022-04-21  3:51   ` Allen-KH Cheng
2022-04-21  3:51   ` Allen-KH Cheng
2022-04-21  3:51 ` [PATCH 4/4] dt-bindings: media: mtk-vcodec: Add encoder power domain property Allen-KH Cheng
2022-04-21  3:51   ` Allen-KH Cheng
2022-04-21  3:51   ` Allen-KH Cheng
2022-04-22 13:47   ` Matthias Brugger
2022-04-22 13:47     ` Matthias Brugger
2022-04-22 13:47     ` Matthias Brugger
2022-04-25 16:37   ` Rob Herring [this message]
2022-04-25 16:37     ` Rob Herring
2022-04-25 16:37     ` Rob Herring
2022-04-22 13:49 ` [PATCH 0/4] Correct power domain for encoder Matthias Brugger
2022-04-22 13:49   ` Matthias Brugger
2022-04-22 13:49   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmbOSHlTLRVzZOtr@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hui.liu@mediatek.com \
    --cc=irui.wang@mediatek.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=ryder.lee@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.