From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
patches@opensource.cirrus.com, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Adam Ford <aford173@gmail.com>
Subject: Re: WM8962 crashing on suspend
Date: Wed, 27 Apr 2022 18:02:12 +0100 [thread overview]
Message-ID: <Yml3FLb4edRWKwTX@sirena.org.uk> (raw)
In-Reply-To: <20220427164825.GH38351@ediswmail.ad.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On Wed, Apr 27, 2022 at 04:48:25PM +0000, Charles Keepax wrote:
> Yeah in my head snd_soc_suspend would have been called which
> would (assuming the DAI doesn't have ignore_suspend set) shut
> down the DAPM graph for the audio route, causing the runtime
> references to all be released and the CODEC to be suspended
> through runtime_pm. Not sure if I missed something there, and
Runtime suspend won't do anything beyond tracking the reference count
when we're in the middle of system suspend IIRC, it won't actually call
the operations.
> that also allows for systems where the CODEC doesn't suspend
> during system suspend. That said guess there probably arn't
> any use-cases for that on wm8962 and I am more than happy to
> use the force_suspend ops if you are happy with it.
The other option would be to move the runtime PM stuff into the bias
level configuration I guess.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-04-27 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 16:36 WM8962 crashing on suspend Adam Ford
2022-04-26 17:32 ` Mark Brown
2022-04-26 17:41 ` Charles Keepax
2022-04-27 13:12 ` Adam Ford
2022-04-27 13:21 ` Mark Brown
2022-04-27 14:58 ` Charles Keepax
2022-04-27 14:57 ` Charles Keepax
2022-04-27 15:24 ` Mark Brown
2022-04-27 16:48 ` Charles Keepax
2022-04-27 16:54 ` Adam Ford
2022-04-28 8:23 ` Charles Keepax
2022-04-28 12:21 ` Adam Ford
2022-04-28 12:45 ` Mark Brown
2022-04-27 17:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yml3FLb4edRWKwTX@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aford173@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.