From: Mark Brown <broonie@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
patches@opensource.cirrus.com, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: WM8962 crashing on suspend
Date: Wed, 27 Apr 2022 14:21:26 +0100 [thread overview]
Message-ID: <YmlDVsDQY3oL8SYs@sirena.org.uk> (raw)
In-Reply-To: <CAHCN7xLqixKxM_L7P9T2BqLpyHoGTYpMODKJotCneXZK+wUEMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Wed, Apr 27, 2022 at 08:12:56AM -0500, Adam Ford wrote:
> I found this:
> static const struct dev_pm_ops wm8962_pm = {
> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
> SET_RUNTIME_PM_OPS(wm8962_runtime_suspend, wm8962_runtime_resume, NULL)
> };
> I applied this, and it appears to make the issue go away on a 5.15
> kernel. I haven't tried it on a 5.18 yet. If this fixes the issue,
> would that be an acceptable solution to push upstream?
Yes, that's fine - it's fixing the thing I was pointing out with only
having runtime suspend but no system suspend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-27 13:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 16:36 WM8962 crashing on suspend Adam Ford
2022-04-26 17:32 ` Mark Brown
2022-04-26 17:41 ` Charles Keepax
2022-04-27 13:12 ` Adam Ford
2022-04-27 13:21 ` Mark Brown [this message]
2022-04-27 14:58 ` Charles Keepax
2022-04-27 14:57 ` Charles Keepax
2022-04-27 15:24 ` Mark Brown
2022-04-27 16:48 ` Charles Keepax
2022-04-27 16:54 ` Adam Ford
2022-04-28 8:23 ` Charles Keepax
2022-04-28 12:21 ` Adam Ford
2022-04-28 12:45 ` Mark Brown
2022-04-27 17:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmlDVsDQY3oL8SYs@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aford173@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.