From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com,
cujomalainey@google.com, ranjani.sridharan@linux.intel.com,
lgirdwood@gmail.com, senozhatsky@chromium.org,
broonie@kernel.org
Subject: Re: [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload
Date: Wed, 27 Apr 2022 22:13:38 +0900 [thread overview]
Message-ID: <YmlBgsQtrayqK0P6@google.com> (raw)
In-Reply-To: <20220427124025.14615-1-peter.ujfalusi@linux.intel.com>
On (22/04/27 15:40), Peter Ujfalusi wrote:
[..]
> struct sof_widget_data {
> int ctrl_type;
> int ipc_cmd;
> - struct sof_abi_hdr *pdata;
> + void *pdata;
> + size_t pdata_size;
> struct snd_sof_control *control;
> };
>
> @@ -784,16 +785,26 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
> }
>
> cdata = wdata[i].control->ipc_control_data;
> - wdata[i].pdata = cdata->data;
> - if (!wdata[i].pdata)
> - return -EINVAL;
>
> /* make sure data is valid - data can be updated at runtime */
A silly nit: does this comment belong to SOF_ABI_MAGIC check below?
> - if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES &&
> - wdata[i].pdata->magic != SOF_ABI_MAGIC)
> - return -EINVAL;
> + if (widget->dobj.widget.kcontrol_type[i] == SND_SOC_TPLG_TYPE_BYTES) {
> + if (cdata->data->magic != SOF_ABI_MAGIC)
> + return -EINVAL;
next prev parent reply other threads:[~2022-04-27 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 12:40 [PATCH v3] ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload Peter Ujfalusi
2022-04-27 13:08 ` Sergey Senozhatsky
2022-04-27 13:09 ` Sergey Senozhatsky
2022-04-27 13:26 ` Sergey Senozhatsky
2022-04-27 13:13 ` Sergey Senozhatsky [this message]
2022-04-27 13:20 ` Sergey Senozhatsky
2022-04-27 18:47 ` Péter Ujfalusi
2022-04-28 2:19 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmlBgsQtrayqK0P6@google.com \
--to=senozhatsky@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.