phosphor-misc: CI Build failure

phosphor-misc: CI Build failure

[i.kononenko]

Hello.                                                                  

Today I was received notice of the phosphor-misc CI build failed due to 
many `shellcheck` verify failed.  The last build (where CI fail was     
found) related to the gerrit change [1] according add support RNDIS and 
EEM network feature, but `shellchek` raise too many error about another 
code that hasn't been changed.                                          
Was I'm miss some changed about Jenkins CI-manifest of phosphor-misc    
that was come most recently? How far I can see the previous changes  
was building successful [2].  Can someone provide link to conversation  
(if it was) related to the phoshpor-misc CI changes?                    
                                                                        
To resolve the issue I'd suggests one of bellow ways:                   
* Disable shellcheck to the `phosphor-misc` via .eslintignore 
* Fix sellcheck errors (preferred).                                         
                                                                        
Thanks.                                                                 
                                                                        
Links:                                                                  
                                                                        
[1] https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-misc/+/53279  
[3] https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-misc/+/48292 

-- 
Best regards,

Igor Kononenko

Re: phosphor-misc: CI Build failure

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

On Wed, Apr 27, 2022 at 04:39:01PM +0300, i.kononenko wrote:
> Hello.                                                                  
> 
> Today I was received notice of the phosphor-misc CI build failed due to 
> many `shellcheck` verify failed.  The last build (where CI fail was     
> found) related to the gerrit change [1] according add support RNDIS and 
> EEM network feature, but `shellchek` raise too many error about another 
> code that hasn't been changed.                                          

I took a look at the failure and it is not due to shellcheck.  We run
shellcheck every where but it only fails the build if the .shellcheck
file is present, which this repo does not have[1].

The failure here is that a more recent version of Meson is upset if
options are passed which are not supported.  This appears to be the case
in this repo:

```
/data0/jenkins/workspace/ci-repository/openbmc/phosphor-misc > meson configure build -Db_sanitize=address,undefined -Db_lundef=false

ERROR: Unknown options: "b_lundef, b_sanitize"
```

We'll need to clean up whatever is going on with the meson calls here.

1. https://github.com/openbmc/openbmc-build-scripts/blob/ac5915f07d3b796f224c85477763ca7fe893dcc2/scripts/format-code.sh#L64

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: phosphor-misc: CI Build failure

[i.kononenko]

Patrick, thanks for response!


On 27.04.2022 19:13, Patrick Williams wrote:
> On Wed, Apr 27, 2022 at 04:39:01PM +0300, i.kononenko wrote:
>> Hello.                                                                  
>>
>> Today I was received notice of the phosphor-misc CI build failed due to 
>> many `shellcheck` verify failed.  The last build (where CI fail was     
>> found) related to the gerrit change [1] according add support RNDIS and 
>> EEM network feature, but `shellchek` raise too many error about another 
>> code that hasn't been changed.                                          
> 
> I took a look at the failure and it is not due to shellcheck.  We run
> shellcheck every where but it only fails the build if the .shellcheck
> file is present, which this repo does not have[1].
> 
> The failure here is that a more recent version of Meson is upset if
> options are passed which are not supported.  This appears to be the case
> in this repo:
> 
> ```
> /data0/jenkins/workspace/ci-repository/openbmc/phosphor-misc > meson configure build -Db_sanitize=address,undefined -Db_lundef=false
> 
> ERROR: Unknown options: "b_lundef, b_sanitize"
> ```

If I understand correctly, the b_lundef and b_sanitize options specifies in the unit-test.py [1].
Unfortunately, I still don't understand the origin of the error. 
Is the `-Db_sanitize=address,undefined -Db_lundef=false` semantic no longer supports in the meson 0.61.3?
I'm a little bit got confused. Could you provide some points where I would might to start to deal with the issue?

> 
> We'll need to clean up whatever is going on with the meson calls here.
> 
> 1. https://github.com/openbmc/openbmc-build-scripts/blob/ac5915f07d3b796f224c85477763ca7fe893dcc2/scripts/format-code.sh#L64
> 

Links:
1. https://github.com/openbmc/openbmc-build-scripts/blob/ac5915f07d3b796f224c85477763ca7fe893dcc2/scripts/unit-test.py#L997

-- 
Best regards,

Igor Kononenko