From: Joerg Roedel <joro@8bytes.org>
To: cgel.zte@gmail.com
Cc: Lv Ruyi <lv.ruyi@zte.com.cn>,
iommu@lists.linux-foundation.org, Zeal Robot <zealci@zte.com.cn>,
will@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: add null pointer check
Date: Thu, 28 Apr 2022 10:18:29 +0200 [thread overview]
Message-ID: <YmpN1ZVZMrU9ZJ3e@8bytes.org> (raw)
In-Reply-To: <20220329055322.2375563-1-lv.ruyi@zte.com.cn>
On Tue, Mar 29, 2022 at 05:53:22AM +0000, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> kmem_cache_zalloc is a memory allocation function which can return NULL
> when some internal memory errors happen. Add null pointer check to avoid
> dereferencing null pointer.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/iommu/fsl_pamu_domain.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/iommu/fsl_pamu_domain.c
> index 69a4a62dc3b9..43849c027298 100644
> --- a/drivers/iommu/fsl_pamu_domain.c
> +++ b/drivers/iommu/fsl_pamu_domain.c
> @@ -152,6 +152,10 @@ static void attach_device(struct fsl_dma_domain *dma_domain, int liodn, struct d
> }
>
> info = kmem_cache_zalloc(iommu_devinfo_cache, GFP_ATOMIC);
> + if (!info) {
> + spin_unlock_irqrestore(&device_domain_lock, flags);
> + return;
> + }
Such errors need to be propagated.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: cgel.zte@gmail.com
Cc: will@kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Lv Ruyi <lv.ruyi@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] iommu: add null pointer check
Date: Thu, 28 Apr 2022 10:18:29 +0200 [thread overview]
Message-ID: <YmpN1ZVZMrU9ZJ3e@8bytes.org> (raw)
In-Reply-To: <20220329055322.2375563-1-lv.ruyi@zte.com.cn>
On Tue, Mar 29, 2022 at 05:53:22AM +0000, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> kmem_cache_zalloc is a memory allocation function which can return NULL
> when some internal memory errors happen. Add null pointer check to avoid
> dereferencing null pointer.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/iommu/fsl_pamu_domain.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/iommu/fsl_pamu_domain.c
> index 69a4a62dc3b9..43849c027298 100644
> --- a/drivers/iommu/fsl_pamu_domain.c
> +++ b/drivers/iommu/fsl_pamu_domain.c
> @@ -152,6 +152,10 @@ static void attach_device(struct fsl_dma_domain *dma_domain, int liodn, struct d
> }
>
> info = kmem_cache_zalloc(iommu_devinfo_cache, GFP_ATOMIC);
> + if (!info) {
> + spin_unlock_irqrestore(&device_domain_lock, flags);
> + return;
> + }
Such errors need to be propagated.
next prev parent reply other threads:[~2022-04-28 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 5:53 [PATCH] iommu: add null pointer check cgel.zte
2022-03-29 5:53 ` cgel.zte
2022-04-28 8:18 ` Joerg Roedel [this message]
2022-04-28 8:18 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmpN1ZVZMrU9ZJ3e@8bytes.org \
--to=joro@8bytes.org \
--cc=cgel.zte@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=will@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.