All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	jmkrzyszt@gmail.com, aaro.koskinen@iki.fi, vireshk@kernel.org,
	shiraz.linux.kernel@gmail.com, nsekhar@ti.com, brgl@bgdev.pl,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 6/6] ARM: omap1: add back omap_set_dma_priority() stub
Date: Fri, 29 Apr 2022 08:32:24 +0300	[thread overview]
Message-ID: <Ymt4aJ2OvNk+Scj/@atomide.com> (raw)
In-Reply-To: <20220428133210.990808-7-arnd@kernel.org>

* Arnd Bergmann <arnd@kernel.org> [220428 13:33]:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> One of my multiplatform patches went a little too far and removed
> a declaration that is needed for compile-testing the omapfb
> driver on non-OMAP1 platforms:
> 
>   arm-linux-gnueabi-ld: drivers/video/fbdev/omap/omapfb_main.o: in function `omapfb_do_probe':
>   omapfb_main.c:(.text+0x41ec): undefined reference to `omap_set_dma_priority'
> 
> Add back the inline stub, and in turn hide the definition when
> omapfb is disabled, like we do for the usb specific bits.

Reviewed-by: Tony Lindgren <tony@atomide.com>

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	jmkrzyszt@gmail.com, aaro.koskinen@iki.fi, vireshk@kernel.org,
	shiraz.linux.kernel@gmail.com, nsekhar@ti.com, brgl@bgdev.pl,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 6/6] ARM: omap1: add back omap_set_dma_priority() stub
Date: Fri, 29 Apr 2022 08:32:24 +0300	[thread overview]
Message-ID: <Ymt4aJ2OvNk+Scj/@atomide.com> (raw)
In-Reply-To: <20220428133210.990808-7-arnd@kernel.org>

* Arnd Bergmann <arnd@kernel.org> [220428 13:33]:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> One of my multiplatform patches went a little too far and removed
> a declaration that is needed for compile-testing the omapfb
> driver on non-OMAP1 platforms:
> 
>   arm-linux-gnueabi-ld: drivers/video/fbdev/omap/omapfb_main.o: in function `omapfb_do_probe':
>   omapfb_main.c:(.text+0x41ec): undefined reference to `omap_set_dma_priority'
> 
> Add back the inline stub, and in turn hide the definition when
> omapfb is disabled, like we do for the usb specific bits.

Reviewed-by: Tony Lindgren <tony@atomide.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-29  5:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 13:31 [PATCH 0/6] ARM: omap/davinci/spear fixes for multiplatform Arnd Bergmann
2022-04-28 13:31 ` Arnd Bergmann
2022-04-28 13:31 ` [PATCH 1/6] ARM: omap2: remove include/mach/ subdirectory Arnd Bergmann
2022-04-28 13:31   ` Arnd Bergmann
2022-04-29  5:33   ` Tony Lindgren
2022-04-29  5:33     ` Tony Lindgren
2022-04-28 13:31 ` [PATCH 2/6] ARM: davinci: " Arnd Bergmann
2022-04-28 13:31   ` Arnd Bergmann
2022-05-02 12:03   ` Bartosz Golaszewski
2022-05-02 12:03     ` Bartosz Golaszewski
2022-04-28 13:31 ` [PATCH 3/6] ARM: spear: " Arnd Bergmann
2022-04-28 13:31   ` Arnd Bergmann
2022-04-29  3:14   ` Viresh Kumar
2022-04-29  3:14     ` Viresh Kumar
2022-04-28 13:31 ` [PATCH 4/6] ARM: omap: fix address space warnings from sparse Arnd Bergmann
2022-04-28 13:31   ` Arnd Bergmann
2022-04-29  5:27   ` Tony Lindgren
2022-04-29  5:27     ` Tony Lindgren
2022-04-28 13:31 ` [PATCH 5/6] ARM: omap2: fix missing declaration warnings Arnd Bergmann
2022-04-28 13:31   ` Arnd Bergmann
2022-04-29  5:32   ` Tony Lindgren
2022-04-29  5:32     ` Tony Lindgren
2022-04-28 13:31 ` [PATCH 6/6] ARM: omap1: add back omap_set_dma_priority() stub Arnd Bergmann
2022-04-28 13:31   ` Arnd Bergmann
2022-04-29  5:32   ` Tony Lindgren [this message]
2022-04-29  5:32     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymt4aJ2OvNk+Scj/@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=jmkrzyszt@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nsekhar@ti.com \
    --cc=shiraz.linux.kernel@gmail.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.