All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: "Steve Dickson" <steved@redhat.com>,
	libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org,
	"Cyril Hrubis" <chrubis@suse.cz>,
	automated-testing@lists.yoctoproject.org,
	"Li Wang" <liwang@redhat.com>,
	"Jan Stancek" <jstancek@redhat.com>,
	"Yang Xu" <xuyang2018.jy@fujitsu.com>,
	"Anders Roxell" <anders.roxell@linaro.org>,
	"Naresh Kamboju" <naresh.kamboju@linaro.org>,
	"Daniel Díaz" <daniel.diaz@linaro.org>,
	"Chuck Lever" <chuck.lever@oracle.com>,
	"J . Bruce Fields" <bfields@fieldses.org>,
	"Trond Myklebust" <trondmy@hammerspace.com>,
	"Veronika Kabatova" <vkabatov@redhat.com>,
	"Alexey Kodanev" <aleksei.kodanev@bell-sw.com>
Subject: Re: [RFC PATCH 0/3] Remove RPC rup and rusers tests
Date: Fri, 29 Apr 2022 09:48:38 +0200	[thread overview]
Message-ID: <YmuYVtvPWxYarLEF@pevik> (raw)
In-Reply-To: <20220428144308.32639-1-pvorel@suse.cz>

Hi all,

I'm sorry, I again used the old mail address of automated-testing ML.
Please have look at this patchset:

https://lore.kernel.org/ltp/20220428144308.32639-1-pvorel@suse.cz/
https://patchwork.ozlabs.org/project/ltp/list/?series=297407&state=*

Kind regards,
Petr

> Hi all,

> IMHO safe to remove these two tests, but sending to broad audience in
> case anybody really want to have these 2 kept (they'd be rewritten to
> new LTP shell API).

> BTW in long term I'd prefer to remove all RPC tests
> (testcases/network/rpc/ directory). IMHO they should be part of libtirpc
> (which has no tests), but these tests are old, messy and I'm not sure
> how relevant they are nowadays.

> Kind regards,
> Petr

> Petr Vorel (3):
>   rpc: Remove rup01.sh test
>   rpc: Remove rusers01.sh test
>   rpc: Move rest of RPC tests to runtest/net.rpc_tests

>  runtest/net.rpc                               |  8 ---
>  runtest/net.rpc_tests                         |  3 ++
>  scenario_groups/network                       |  1 -
>  .../network/rpc/basic_tests/rup/Makefile      | 29 -----------
>  .../network/rpc/basic_tests/rup/rup01.sh      | 50 -------------------
>  .../network/rpc/basic_tests/rusers/Makefile   | 29 -----------
>  .../rpc/basic_tests/rusers/rusers01.sh        | 50 -------------------
>  testscripts/network.sh                        |  4 +-
>  8 files changed, 4 insertions(+), 170 deletions(-)
>  delete mode 100644 runtest/net.rpc
>  delete mode 100644 testcases/network/rpc/basic_tests/rup/Makefile
>  delete mode 100755 testcases/network/rpc/basic_tests/rup/rup01.sh
>  delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile
>  delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: linux-nfs@vger.kernel.org, libtirpc-devel@lists.sourceforge.net,
	Steve Dickson <steved@redhat.com>,
	"J . Bruce Fields" <bfields@fieldses.org>,
	Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <trondmy@hammerspace.com>,
	automated-testing@lists.yoctoproject.org
Subject: Re: [LTP] [RFC PATCH 0/3] Remove RPC rup and rusers tests
Date: Fri, 29 Apr 2022 09:48:38 +0200	[thread overview]
Message-ID: <YmuYVtvPWxYarLEF@pevik> (raw)
In-Reply-To: <20220428144308.32639-1-pvorel@suse.cz>

Hi all,

I'm sorry, I again used the old mail address of automated-testing ML.
Please have look at this patchset:

https://lore.kernel.org/ltp/20220428144308.32639-1-pvorel@suse.cz/
https://patchwork.ozlabs.org/project/ltp/list/?series=297407&state=*

Kind regards,
Petr

> Hi all,

> IMHO safe to remove these two tests, but sending to broad audience in
> case anybody really want to have these 2 kept (they'd be rewritten to
> new LTP shell API).

> BTW in long term I'd prefer to remove all RPC tests
> (testcases/network/rpc/ directory). IMHO they should be part of libtirpc
> (which has no tests), but these tests are old, messy and I'm not sure
> how relevant they are nowadays.

> Kind regards,
> Petr

> Petr Vorel (3):
>   rpc: Remove rup01.sh test
>   rpc: Remove rusers01.sh test
>   rpc: Move rest of RPC tests to runtest/net.rpc_tests

>  runtest/net.rpc                               |  8 ---
>  runtest/net.rpc_tests                         |  3 ++
>  scenario_groups/network                       |  1 -
>  .../network/rpc/basic_tests/rup/Makefile      | 29 -----------
>  .../network/rpc/basic_tests/rup/rup01.sh      | 50 -------------------
>  .../network/rpc/basic_tests/rusers/Makefile   | 29 -----------
>  .../rpc/basic_tests/rusers/rusers01.sh        | 50 -------------------
>  testscripts/network.sh                        |  4 +-
>  8 files changed, 4 insertions(+), 170 deletions(-)
>  delete mode 100644 runtest/net.rpc
>  delete mode 100644 testcases/network/rpc/basic_tests/rup/Makefile
>  delete mode 100755 testcases/network/rpc/basic_tests/rup/rup01.sh
>  delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile
>  delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-04-29  7:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 14:43 [RFC PATCH 0/3] Remove RPC rup and rusers tests Petr Vorel
2022-04-28 14:43 ` [LTP] " Petr Vorel
2022-04-28 14:43 ` [RFC PATCH 1/3] rpc: Remove rup01.sh test Petr Vorel
2022-04-28 14:43   ` [LTP] " Petr Vorel
2022-04-28 14:43 ` [RFC PATCH 2/3] rpc: Remove rusers01.sh test Petr Vorel
2022-04-28 14:43   ` [LTP] " Petr Vorel
2022-04-28 14:43 ` [RFC PATCH 3/3] rpc: Move rest of RPC tests to runtest/net.rpc_tests Petr Vorel
2022-04-28 14:43   ` [LTP] " Petr Vorel
2022-04-29  7:48 ` Petr Vorel [this message]
2022-04-29  7:48   ` [LTP] [RFC PATCH 0/3] Remove RPC rup and rusers tests Petr Vorel
2022-05-12 14:37 ` Cyril Hrubis
2022-05-12 14:37   ` [LTP] " Cyril Hrubis
2022-05-12 14:46   ` Petr Vorel
2022-05-12 14:46     ` [LTP] " Petr Vorel
2022-05-12 14:54     ` Cyril Hrubis
2022-05-12 14:54       ` [LTP] " Cyril Hrubis
2022-05-12 15:06       ` Petr Vorel
2022-05-12 15:06         ` [LTP] " Petr Vorel
2022-05-31 13:27 ` Cyril Hrubis
2022-05-31 13:27   ` [LTP] " Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmuYVtvPWxYarLEF@pevik \
    --to=pvorel@suse.cz \
    --cc=aleksei.kodanev@bell-sw.com \
    --cc=anders.roxell@linaro.org \
    --cc=automated-testing@lists.yoctoproject.org \
    --cc=bfields@fieldses.org \
    --cc=chrubis@suse.cz \
    --cc=chuck.lever@oracle.com \
    --cc=daniel.diaz@linaro.org \
    --cc=jstancek@redhat.com \
    --cc=libtirpc-devel@lists.sourceforge.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=naresh.kamboju@linaro.org \
    --cc=steved@redhat.com \
    --cc=trondmy@hammerspace.com \
    --cc=vkabatov@redhat.com \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.