All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Linu Cherian <lcherian@marvell.com>
Cc: maz@kernel.org, will@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuc.decode@gmail.com,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] arm64: Declare non global symbols as static
Date: Fri, 29 Apr 2022 20:06:13 +0100	[thread overview]
Message-ID: <Ymw3JY5m1R0W8/l5@arm.com> (raw)
In-Reply-To: <20220429075535.10636-1-lcherian@marvell.com>

On Fri, Apr 29, 2022 at 01:25:35PM +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
> 
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
> arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol
> 'cavium_erratum_27456_cpus' was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> ---
>  arch/arm64/kernel/cpu_errata.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 4c9b5b4b7a0b..57a39cb6b489 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
>  #endif
>  
>  #ifdef CONFIG_CAVIUM_ERRATUM_23154
> -const struct midr_range cavium_erratum_23154_cpus[] = {
> +static const struct midr_range cavium_erratum_23154_cpus[] = {
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX),
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),
> @@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = {
>  #endif
>  
>  #ifdef CONFIG_CAVIUM_ERRATUM_27456
> -const struct midr_range cavium_erratum_27456_cpus[] = {
> +static const struct midr_range cavium_erratum_27456_cpus[] = {
>  	/* Cavium ThunderX, T88 pass 1.x - 2.1 */
>  	MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1),
>  	/* Cavium ThunderX, T81 pass 1.0 */

That's referred in arch/arm64/kernel/cpufeature.c, so the build fails.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Linu Cherian <lcherian@marvell.com>
Cc: maz@kernel.org, will@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuc.decode@gmail.com,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] arm64: Declare non global symbols as static
Date: Fri, 29 Apr 2022 20:06:13 +0100	[thread overview]
Message-ID: <Ymw3JY5m1R0W8/l5@arm.com> (raw)
In-Reply-To: <20220429075535.10636-1-lcherian@marvell.com>

On Fri, Apr 29, 2022 at 01:25:35PM +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
> 
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
> arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol
> 'cavium_erratum_27456_cpus' was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> ---
>  arch/arm64/kernel/cpu_errata.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 4c9b5b4b7a0b..57a39cb6b489 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
>  #endif
>  
>  #ifdef CONFIG_CAVIUM_ERRATUM_23154
> -const struct midr_range cavium_erratum_23154_cpus[] = {
> +static const struct midr_range cavium_erratum_23154_cpus[] = {
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX),
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
>  	MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),
> @@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = {
>  #endif
>  
>  #ifdef CONFIG_CAVIUM_ERRATUM_27456
> -const struct midr_range cavium_erratum_27456_cpus[] = {
> +static const struct midr_range cavium_erratum_27456_cpus[] = {
>  	/* Cavium ThunderX, T88 pass 1.x - 2.1 */
>  	MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1),
>  	/* Cavium ThunderX, T81 pass 1.0 */

That's referred in arch/arm64/kernel/cpufeature.c, so the build fails.

-- 
Catalin

  parent reply	other threads:[~2022-04-29 19:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29  7:55 [PATCH] arm64: Declare non global symbols as static Linu Cherian
2022-04-29  7:55 ` Linu Cherian
2022-04-29 16:13 ` Marc Zyngier
2022-04-29 19:06 ` Catalin Marinas [this message]
2022-04-29 19:06   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymw3JY5m1R0W8/l5@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=lcherian@marvell.com \
    --cc=linuc.decode@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=maz@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.