From: Eric Biggers <ebiggers@kernel.org>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Lukas Czerner <lczerner@redhat.com>,
Theodore Ts'o <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH v2 5/7] ext4: fix up test_dummy_encryption handling for new mount API
Date: Fri, 13 May 2022 14:59:57 -0700 [thread overview]
Message-ID: <Yn7U3YHQfoRaeQPQ@sol.localdomain> (raw)
In-Reply-To: <20220513110741.uofbacfs7li4cqio@riteshh-domain>
On Fri, May 13, 2022 at 04:37:41PM +0530, Ritesh Harjani wrote:
> > @@ -2623,10 +2609,11 @@ static int parse_apply_sb_mount_options(struct super_block *sb,
> > if (s_ctx->spec & EXT4_SPEC_JOURNAL_IOPRIO)
> > m_ctx->journal_ioprio = s_ctx->journal_ioprio;
> >
> > - ret = ext4_apply_options(fc, sb);
> > + ext4_apply_options(fc, sb);
> > + ret = 0;
> >
> > out_free:
> > - kfree(s_ctx);
> > + __ext4_fc_free(s_ctx);
>
> I think we can still call ext4_fc_free(fc) and we don't need __ext4_fc_free().
> Right?
>
Yes, you're right. I might have missed that fc->fs_private was being set above.
I was also a little lazy here; the part below 'out_free:' should be a separate
patch since it also fixes a memory leak of s_qf_names. I'll fix that up.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Jeff Layton <jlayton@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org,
Lukas Czerner <lczerner@redhat.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 5/7] ext4: fix up test_dummy_encryption handling for new mount API
Date: Fri, 13 May 2022 14:59:57 -0700 [thread overview]
Message-ID: <Yn7U3YHQfoRaeQPQ@sol.localdomain> (raw)
In-Reply-To: <20220513110741.uofbacfs7li4cqio@riteshh-domain>
On Fri, May 13, 2022 at 04:37:41PM +0530, Ritesh Harjani wrote:
> > @@ -2623,10 +2609,11 @@ static int parse_apply_sb_mount_options(struct super_block *sb,
> > if (s_ctx->spec & EXT4_SPEC_JOURNAL_IOPRIO)
> > m_ctx->journal_ioprio = s_ctx->journal_ioprio;
> >
> > - ret = ext4_apply_options(fc, sb);
> > + ext4_apply_options(fc, sb);
> > + ret = 0;
> >
> > out_free:
> > - kfree(s_ctx);
> > + __ext4_fc_free(s_ctx);
>
> I think we can still call ext4_fc_free(fc) and we don't need __ext4_fc_free().
> Right?
>
Yes, you're right. I might have missed that fc->fs_private was being set above.
I was also a little lazy here; the part below 'out_free:' should be a separate
patch since it also fixes a memory leak of s_qf_names. I'll fix that up.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-05-13 22:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 5:08 [PATCH v2 0/7] test_dummy_encryption fixes and cleanups Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-01 5:08 ` [PATCH v2 1/7] ext4: only allow test_dummy_encryption when supported Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-11 12:50 ` Ritesh Harjani
2022-05-11 12:50 ` [f2fs-dev] " Ritesh Harjani
2022-05-11 17:18 ` Eric Biggers
2022-05-11 17:18 ` [f2fs-dev] " Eric Biggers
2022-05-01 5:08 ` [PATCH v2 2/7] f2fs: reject test_dummy_encryption when !CONFIG_FS_ENCRYPTION Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-01 5:08 ` [PATCH v2 3/7] fscrypt: factor out fscrypt_policy_to_key_spec() Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-01 5:08 ` [PATCH v2 4/7] fscrypt: add new helper functions for test_dummy_encryption Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-01 5:08 ` [PATCH v2 5/7] ext4: fix up test_dummy_encryption handling for new mount API Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-09 23:40 ` Eric Biggers
2022-05-09 23:40 ` [f2fs-dev] " Eric Biggers
2022-05-11 17:54 ` Ritesh Harjani
2022-05-11 17:54 ` Ritesh Harjani
2022-05-11 18:03 ` Eric Biggers
2022-05-11 18:03 ` Eric Biggers
2022-05-13 10:58 ` Ritesh Harjani
2022-05-13 10:58 ` Ritesh Harjani
2022-05-13 22:24 ` Eric Biggers
2022-05-13 22:24 ` [f2fs-dev] " Eric Biggers
2022-05-13 11:07 ` Ritesh Harjani
2022-05-13 11:07 ` [f2fs-dev] " Ritesh Harjani
2022-05-13 21:59 ` Eric Biggers [this message]
2022-05-13 21:59 ` Eric Biggers
2022-05-01 5:08 ` [PATCH v2 6/7] f2fs: use the updated test_dummy_encryption helper functions Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-01 5:08 ` [PATCH v2 7/7] fscrypt: remove fscrypt_set_test_dummy_encryption() Eric Biggers
2022-05-01 5:08 ` [f2fs-dev] " Eric Biggers
2022-05-09 23:36 ` [PATCH v2 0/7] test_dummy_encryption fixes and cleanups Eric Biggers
2022-05-09 23:36 ` [f2fs-dev] " Eric Biggers
2022-05-10 23:23 ` Jaegeuk Kim
2022-05-10 23:23 ` [f2fs-dev] " Jaegeuk Kim
2022-05-13 19:36 ` Theodore Ts'o
2022-05-13 19:36 ` [f2fs-dev] " Theodore Ts'o
2022-05-13 23:26 ` Eric Biggers
2022-05-13 23:26 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn7U3YHQfoRaeQPQ@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.