All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Tero Kristo <kristo@kernel.org>, Nishanth Menon <nm@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/6] dt-bindings: ti,sci: Add lpm region and ti,lpm-firmware-name
Date: Mon, 2 May 2022 15:15:36 -0500	[thread overview]
Message-ID: <YnA76FFG0wW1Jzrs@robh.at.kernel.org> (raw)
In-Reply-To: <20220421203659.27853-3-d-gerlach@ti.com>

On Thu, Apr 21, 2022 at 03:36:55PM -0500, Dave Gerlach wrote:
> Add documentation for the lpm region which tells the ti-sci driver where
> to load the FS Stub low power mode firmware and also the
> ti,lpm-firmware-name which tells the driver which binary to load. Both
> of these are optional for normal system operation but required to
> enabled suspend-to-mem usage of Deep Sleep state.
> 
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
>  .../bindings/arm/keystone/ti,sci.yaml         | 21 +++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index ec88aa88a2a0..31c783507cd0 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -42,12 +42,19 @@ properties:
>            - const: ti,am654-sci
>  
>    reg-names:
> -    description: |
> -      Specifies the debug messages memory mapped region that is optionally
> -      made available from TI-SCI controller.
> -    const: debug_messages
> +    items:
> +      - const: debug_messages
> +      - const: lpm
> +    minItems: 1
>  
>    reg:
> +    items:
> +      - description: |
> +          Specifies the debug messages memory mapped region that is optionally
> +          made available from TI-SCI controller.
> +      - description: |
> +          Specifies the lpm memory mapped region where the FS Stub low power
> +          firmware is to be loaded.
>      minItems: 1
>  
>    mbox-names:
> @@ -92,6 +99,12 @@ properties:
>      type: object
>      $ref: /schemas/reset/ti,sci-reset.yaml#
>  
> +  ti,lpm-firmware-name:

firmware-name

> +    description: |
> +      Name of binary of FS Stub low power firmware located on the
> +      firmware search path.
> +    $ref: /schemas/types.yaml#/definitions/string
> +
>  required:
>    - compatible
>    - mbox-names
> -- 
> 2.35.0
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Tero Kristo <kristo@kernel.org>, Nishanth Menon <nm@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/6] dt-bindings: ti,sci: Add lpm region and ti,lpm-firmware-name
Date: Mon, 2 May 2022 15:15:36 -0500	[thread overview]
Message-ID: <YnA76FFG0wW1Jzrs@robh.at.kernel.org> (raw)
In-Reply-To: <20220421203659.27853-3-d-gerlach@ti.com>

On Thu, Apr 21, 2022 at 03:36:55PM -0500, Dave Gerlach wrote:
> Add documentation for the lpm region which tells the ti-sci driver where
> to load the FS Stub low power mode firmware and also the
> ti,lpm-firmware-name which tells the driver which binary to load. Both
> of these are optional for normal system operation but required to
> enabled suspend-to-mem usage of Deep Sleep state.
> 
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
>  .../bindings/arm/keystone/ti,sci.yaml         | 21 +++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index ec88aa88a2a0..31c783507cd0 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -42,12 +42,19 @@ properties:
>            - const: ti,am654-sci
>  
>    reg-names:
> -    description: |
> -      Specifies the debug messages memory mapped region that is optionally
> -      made available from TI-SCI controller.
> -    const: debug_messages
> +    items:
> +      - const: debug_messages
> +      - const: lpm
> +    minItems: 1
>  
>    reg:
> +    items:
> +      - description: |
> +          Specifies the debug messages memory mapped region that is optionally
> +          made available from TI-SCI controller.
> +      - description: |
> +          Specifies the lpm memory mapped region where the FS Stub low power
> +          firmware is to be loaded.
>      minItems: 1
>  
>    mbox-names:
> @@ -92,6 +99,12 @@ properties:
>      type: object
>      $ref: /schemas/reset/ti,sci-reset.yaml#
>  
> +  ti,lpm-firmware-name:

firmware-name

> +    description: |
> +      Name of binary of FS Stub low power firmware located on the
> +      firmware search path.
> +    $ref: /schemas/types.yaml#/definitions/string
> +
>  required:
>    - compatible
>    - mbox-names
> -- 
> 2.35.0
> 
> 

  reply	other threads:[~2022-05-02 20:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 20:36 [PATCH 0/6] firmware: ti_sci: Introduce system suspend support Dave Gerlach
2022-04-21 20:36 ` Dave Gerlach
2022-04-21 20:36 ` [PATCH 1/6] dt-bindings: ti,sci: Add ti,ctx-memory-region property Dave Gerlach
2022-04-21 20:36   ` Dave Gerlach
2022-04-22 19:02   ` Andrew Davis
2022-04-22 19:02     ` Andrew Davis
2022-04-22 19:02     ` Andrew Davis
2022-04-22 19:10     ` Dave Gerlach
2022-04-22 19:10       ` Dave Gerlach
2022-04-23 13:36       ` Nishanth Menon
2022-04-23 13:36         ` Nishanth Menon
2022-04-25 20:24         ` Dave Gerlach
2022-04-25 20:24           ` Dave Gerlach
2022-04-26  3:28           ` Nishanth Menon
2022-04-26  3:28             ` Nishanth Menon
2022-05-02 20:14   ` Rob Herring
2022-05-02 20:14     ` Rob Herring
2022-04-21 20:36 ` [PATCH 2/6] dt-bindings: ti, sci: Add lpm region and ti, lpm-firmware-name Dave Gerlach
2022-04-21 20:36   ` [PATCH 2/6] dt-bindings: ti,sci: Add lpm region and ti,lpm-firmware-name Dave Gerlach
2022-05-02 20:15   ` Rob Herring [this message]
2022-05-02 20:15     ` Rob Herring
2022-04-21 20:36 ` [PATCH 3/6] firmware: ti_sci: Introduce Power Management Ops Dave Gerlach
2022-04-21 20:36   ` Dave Gerlach
2022-04-21 20:36 ` [PATCH 4/6] firmware: ti_sci: Introduce ti, ctx-memory-region for reserved LPM memory Dave Gerlach
2022-04-21 20:36   ` [PATCH 4/6] firmware: ti_sci: Introduce ti,ctx-memory-region " Dave Gerlach
2022-04-21 20:36 ` [PATCH 5/6] firmware: ti_sci: Use dt provided fw name and address to load at suspend time Dave Gerlach
2022-04-21 20:36   ` Dave Gerlach
2022-04-21 20:36 ` [PATCH 6/6] firmware: ti_sci: Introduce prepare system suspend call Dave Gerlach
2022-04-21 20:36   ` Dave Gerlach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnA76FFG0wW1Jzrs@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.