From: Stafford Horne <shorne@gmail.com>
To: openrisc@lists.librecores.org
Subject: [PATCH] openrisc: remove bogus nops and shutdowns
Date: Thu, 5 May 2022 07:24:50 +0900 [thread overview]
Message-ID: <YnL9MuVLtiGWD2EV@antec> (raw)
In-Reply-To: <20220504110911.283525-1-Jason@zx2c4.com>
On Wed, May 04, 2022 at 01:09:11PM +0200, Jason A. Donenfeld wrote:
> Nop 42 is some leftover debugging thing by the looks of it. Nop 1 will
> shut down the simulator, which isn't what we want, since it makes it
> possible to handle errors.
Do you mean impossible to handler errors?
> Cc: Stafford Horne <shorne@gmail.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This looks good to me, I didn't add these debug's I think we can remove them.
-Stafford
> ---
> arch/openrisc/mm/fault.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
> index 80bb66ad42f6..860da58d7509 100644
> --- a/arch/openrisc/mm/fault.c
> +++ b/arch/openrisc/mm/fault.c
> @@ -223,8 +223,6 @@ asmlinkage void do_page_fault(struct pt_regs *regs, unsigned long address,
> {
> const struct exception_table_entry *entry;
>
> - __asm__ __volatile__("l.nop 42");
> -
> if ((entry = search_exception_tables(regs->pc)) != NULL) {
> /* Adjust the instruction pointer in the stackframe */
> regs->pc = entry->fixup;
> @@ -252,9 +250,6 @@ asmlinkage void do_page_fault(struct pt_regs *regs, unsigned long address,
> */
>
> out_of_memory:
> - __asm__ __volatile__("l.nop 42");
> - __asm__ __volatile__("l.nop 1");
> -
> mmap_read_unlock(mm);
> if (!user_mode(regs))
> goto no_context;
> --
> 2.35.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: openrisc@lists.librecores.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openrisc: remove bogus nops and shutdowns
Date: Thu, 5 May 2022 07:24:50 +0900 [thread overview]
Message-ID: <YnL9MuVLtiGWD2EV@antec> (raw)
In-Reply-To: <20220504110911.283525-1-Jason@zx2c4.com>
On Wed, May 04, 2022 at 01:09:11PM +0200, Jason A. Donenfeld wrote:
> Nop 42 is some leftover debugging thing by the looks of it. Nop 1 will
> shut down the simulator, which isn't what we want, since it makes it
> possible to handle errors.
Do you mean impossible to handler errors?
> Cc: Stafford Horne <shorne@gmail.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
This looks good to me, I didn't add these debug's I think we can remove them.
-Stafford
> ---
> arch/openrisc/mm/fault.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
> index 80bb66ad42f6..860da58d7509 100644
> --- a/arch/openrisc/mm/fault.c
> +++ b/arch/openrisc/mm/fault.c
> @@ -223,8 +223,6 @@ asmlinkage void do_page_fault(struct pt_regs *regs, unsigned long address,
> {
> const struct exception_table_entry *entry;
>
> - __asm__ __volatile__("l.nop 42");
> -
> if ((entry = search_exception_tables(regs->pc)) != NULL) {
> /* Adjust the instruction pointer in the stackframe */
> regs->pc = entry->fixup;
> @@ -252,9 +250,6 @@ asmlinkage void do_page_fault(struct pt_regs *regs, unsigned long address,
> */
>
> out_of_memory:
> - __asm__ __volatile__("l.nop 42");
> - __asm__ __volatile__("l.nop 1");
> -
> mmap_read_unlock(mm);
> if (!user_mode(regs))
> goto no_context;
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-05-04 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 11:09 [PATCH] openrisc: remove bogus nops and shutdowns Jason A. Donenfeld
2022-05-04 11:09 ` Jason A. Donenfeld
2022-05-04 22:24 ` Stafford Horne [this message]
2022-05-04 22:24 ` Stafford Horne
2022-05-04 23:19 ` Jason A. Donenfeld
2022-05-04 23:19 ` Jason A. Donenfeld
2022-05-11 13:35 ` [PATCH v2] " Jason A. Donenfeld
2022-05-11 13:35 ` Jason A. Donenfeld
2022-05-11 20:54 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnL9MuVLtiGWD2EV@antec \
--to=shorne@gmail.com \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.