From: Rob Herring <robh@kernel.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
linux-kernel@vger.kernel.org,
Shane Chien <shane.chien@mediatek.com>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
kernel@collabora.com, linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties
Date: Wed, 4 May 2022 15:38:56 -0500 [thread overview]
Message-ID: <YnLkYKmJ0TJ8uyjC@robh.at.kernel.org> (raw)
In-Reply-To: <20220429203039.2207848-2-nfraprado@collabora.com>
On Fri, Apr 29, 2022 at 04:30:37PM -0400, Nícolas F. R. A. Prado wrote:
> The Mediatek AFE PCM controller for MT8192 allows sharing of an I2S bus
> between two busses. Add a pattern for these properties in the
> dt-binding.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> index 7a25bc9b8060..5b03c8dbf318 100644
> --- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> @@ -54,6 +54,11 @@ properties:
> - const: aud_infra_clk
> - const: aud_infra_26m_clk
>
> +patternProperties:
> + "^i2s[0-35-9]-share$":
> + description: Name of the I2S bus that is shared with this bus
> + pattern: "^I2S[0-35-9]$"
Why not a phandle to the the other bus? That would be the DT way to do
it. But I'm not sure I really understand who is sharing what here.
> +
> required:
> - compatible
> - interrupts
> --
> 2.36.0
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Mark Brown <broonie@kernel.org>,
kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Shane Chien <shane.chien@mediatek.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties
Date: Wed, 4 May 2022 15:38:56 -0500 [thread overview]
Message-ID: <YnLkYKmJ0TJ8uyjC@robh.at.kernel.org> (raw)
In-Reply-To: <20220429203039.2207848-2-nfraprado@collabora.com>
On Fri, Apr 29, 2022 at 04:30:37PM -0400, Nícolas F. R. A. Prado wrote:
> The Mediatek AFE PCM controller for MT8192 allows sharing of an I2S bus
> between two busses. Add a pattern for these properties in the
> dt-binding.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> index 7a25bc9b8060..5b03c8dbf318 100644
> --- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> @@ -54,6 +54,11 @@ properties:
> - const: aud_infra_clk
> - const: aud_infra_26m_clk
>
> +patternProperties:
> + "^i2s[0-35-9]-share$":
> + description: Name of the I2S bus that is shared with this bus
> + pattern: "^I2S[0-35-9]$"
Why not a phandle to the the other bus? That would be the DT way to do
it. But I'm not sure I really understand who is sharing what here.
> +
> required:
> - compatible
> - interrupts
> --
> 2.36.0
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Mark Brown <broonie@kernel.org>,
kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Shane Chien <shane.chien@mediatek.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties
Date: Wed, 4 May 2022 15:38:56 -0500 [thread overview]
Message-ID: <YnLkYKmJ0TJ8uyjC@robh.at.kernel.org> (raw)
In-Reply-To: <20220429203039.2207848-2-nfraprado@collabora.com>
On Fri, Apr 29, 2022 at 04:30:37PM -0400, Nícolas F. R. A. Prado wrote:
> The Mediatek AFE PCM controller for MT8192 allows sharing of an I2S bus
> between two busses. Add a pattern for these properties in the
> dt-binding.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> index 7a25bc9b8060..5b03c8dbf318 100644
> --- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> @@ -54,6 +54,11 @@ properties:
> - const: aud_infra_clk
> - const: aud_infra_26m_clk
>
> +patternProperties:
> + "^i2s[0-35-9]-share$":
> + description: Name of the I2S bus that is shared with this bus
> + pattern: "^I2S[0-35-9]$"
Why not a phandle to the the other bus? That would be the DT way to do
it. But I'm not sure I really understand who is sharing what here.
> +
> required:
> - compatible
> - interrupts
> --
> 2.36.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Mark Brown <broonie@kernel.org>,
kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Shane Chien <shane.chien@mediatek.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties
Date: Wed, 4 May 2022 15:38:56 -0500 [thread overview]
Message-ID: <YnLkYKmJ0TJ8uyjC@robh.at.kernel.org> (raw)
In-Reply-To: <20220429203039.2207848-2-nfraprado@collabora.com>
On Fri, Apr 29, 2022 at 04:30:37PM -0400, Nícolas F. R. A. Prado wrote:
> The Mediatek AFE PCM controller for MT8192 allows sharing of an I2S bus
> between two busses. Add a pattern for these properties in the
> dt-binding.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> index 7a25bc9b8060..5b03c8dbf318 100644
> --- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
> @@ -54,6 +54,11 @@ properties:
> - const: aud_infra_clk
> - const: aud_infra_26m_clk
>
> +patternProperties:
> + "^i2s[0-35-9]-share$":
> + description: Name of the I2S bus that is shared with this bus
> + pattern: "^I2S[0-35-9]$"
Why not a phandle to the the other bus? That would be the DT way to do
it. But I'm not sure I really understand who is sharing what here.
> +
> required:
> - compatible
> - interrupts
> --
> 2.36.0
>
>
next prev parent reply other threads:[~2022-05-04 20:40 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 20:30 [PATCH 0/3] Add missing dt-binding properties for audio components on mt8192-asurada Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-04-29 20:30 ` [PATCH 1/3] ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-05-04 20:38 ` Rob Herring [this message]
2022-05-04 20:38 ` Rob Herring
2022-05-04 20:38 ` Rob Herring
2022-05-04 20:38 ` Rob Herring
2022-05-05 2:13 ` Jiaxin Yu
2022-05-05 2:13 ` Jiaxin Yu
2022-05-05 2:13 ` Jiaxin Yu
2022-05-05 2:13 ` Jiaxin Yu
2022-05-05 8:08 ` AngeloGioacchino Del Regno
2022-05-05 8:08 ` AngeloGioacchino Del Regno
2022-05-05 8:08 ` AngeloGioacchino Del Regno
2022-05-05 8:08 ` AngeloGioacchino Del Regno
2022-05-05 8:48 ` Jiaxin Yu
2022-05-05 8:48 ` Jiaxin Yu
2022-05-05 8:48 ` Jiaxin Yu
2022-05-05 8:48 ` Jiaxin Yu
2022-05-05 8:52 ` AngeloGioacchino Del Regno
2022-05-05 8:52 ` AngeloGioacchino Del Regno
2022-05-05 8:52 ` AngeloGioacchino Del Regno
2022-05-05 8:52 ` AngeloGioacchino Del Regno
2022-05-05 16:25 ` Nícolas F. R. A. Prado
2022-05-05 16:25 ` Nícolas F. R. A. Prado
2022-05-05 16:25 ` Nícolas F. R. A. Prado
2022-05-05 16:25 ` Nícolas F. R. A. Prado
2022-05-06 5:45 ` Jiaxin Yu
2022-05-06 5:45 ` Jiaxin Yu
2022-05-06 5:45 ` Jiaxin Yu
2022-05-06 5:45 ` Jiaxin Yu
2022-05-06 14:09 ` Nícolas F. R. A. Prado
2022-05-06 14:09 ` Nícolas F. R. A. Prado
2022-05-06 14:09 ` Nícolas F. R. A. Prado
2022-05-06 14:09 ` Nícolas F. R. A. Prado
2022-05-06 14:44 ` Jiaxin Yu
2022-05-06 14:44 ` Jiaxin Yu
2022-05-06 14:44 ` Jiaxin Yu
2022-05-06 14:44 ` Jiaxin Yu
2022-04-29 20:30 ` [PATCH 2/3] ASoC: dt-bindings: rt1015p: Add #sound-dai-cells Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-05-04 20:39 ` Rob Herring
2022-05-04 20:39 ` Rob Herring
2022-04-29 20:30 ` [PATCH 3/3] ASoC: dt-bindings: rt5682: " Nícolas F. R. A. Prado
2022-04-29 20:30 ` Nícolas F. R. A. Prado
2022-05-04 20:39 ` Rob Herring
2022-05-04 20:39 ` Rob Herring
2022-05-09 17:17 ` [PATCH 0/3] Add missing dt-binding properties for audio components on mt8192-asurada Mark Brown
2022-05-09 17:17 ` Mark Brown
2022-05-09 17:17 ` Mark Brown
2022-05-09 17:17 ` Mark Brown
2022-05-09 18:16 ` Nícolas F. R. A. Prado
2022-05-09 18:16 ` Nícolas F. R. A. Prado
2022-05-09 18:16 ` Nícolas F. R. A. Prado
2022-05-09 18:16 ` Nícolas F. R. A. Prado
2022-05-09 18:19 ` Mark Brown
2022-05-09 18:19 ` Mark Brown
2022-05-09 18:19 ` Mark Brown
2022-05-09 18:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnLkYKmJ0TJ8uyjC@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=shane.chien@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.