Re: [PATCH v3 3/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

[Daniel Vetter <daniel@ffwll.ch>]

On Thu, May 05, 2022 at 02:45:27PM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
> 
> On 5/5/22 14:11, Daniel Vetter wrote:
> 
> [snip]
> 
> >>
> >> And while I agree with you that these midlayer flags are horrible, that is
> >> what any other fbdev that makes use of a firmware-provided framebuffer set,
> >> so simpledrm emulated fbdev shouldn't be the exception IMO.
> > 
> > So we discussed this a pile more on irc, and at least my take is that
> > people who run simpledrm but want to combine that with fbdev drivers and
> > expect it to all work nicely we can probably ignore. At least until all
> > this sysfb stuff is nicely unified, and at that point we shouldn't need
> > special flags anymore.
> 
> I'm OK with this take and happy to just drop this patch-set then. My worry
> was just that someone could complain that we broke their uncommon setup [0].
> 
> [0]: https://xkcd.com/1172/.

Since you have to explicitly enable simpledrm and that combo never
worked, we did not actually break anything.

Me, who has over a decade experience legalesing around the "no regression"
rule :-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch