From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline
Date: Fri, 6 May 2022 13:07:13 +0800 [thread overview]
Message-ID: <YnStAT+Mudy1xslV@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20220506043226.125611-1-sensor1010@163.com>
Add Andrew to CC list
On 05/05/22 at 09:32pm, lizhe wrote:
> At the end of get_last_crashkernel(), the judgement of ck_cmdline is
> obviously unnecessary and causes redundance, let's clean it up.
>
> Signed-off-by: lizhe <sensor1010@163.com>
> Acked-by: Baoquan He <bhe@redhat.com>
> Acked-by: Philipp Rudo <prudo@redhat.com>
> ---
> kernel/crash_core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 256cf6db573c..c232f01a2c54 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> p = strstr(p+1, name);
> }
>
> - if (!ck_cmdline)
> - return NULL;
> -
> return ck_cmdline;
> }
>
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: lizhe <sensor1010@163.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: vgoyal@redhat.com, dyoung@redhat.com, prudo@redhat.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline
Date: Fri, 6 May 2022 13:07:13 +0800 [thread overview]
Message-ID: <YnStAT+Mudy1xslV@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20220506043226.125611-1-sensor1010@163.com>
Add Andrew to CC list
On 05/05/22 at 09:32pm, lizhe wrote:
> At the end of get_last_crashkernel(), the judgement of ck_cmdline is
> obviously unnecessary and causes redundance, let's clean it up.
>
> Signed-off-by: lizhe <sensor1010@163.com>
> Acked-by: Baoquan He <bhe@redhat.com>
> Acked-by: Philipp Rudo <prudo@redhat.com>
> ---
> kernel/crash_core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 256cf6db573c..c232f01a2c54 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> p = strstr(p+1, name);
> }
>
> - if (!ck_cmdline)
> - return NULL;
> -
> return ck_cmdline;
> }
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-05-06 5:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 4:32 [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline lizhe
2022-05-06 4:32 ` lizhe
2022-05-06 5:07 ` Baoquan He [this message]
2022-05-06 5:07 ` Baoquan He
2022-05-06 5:28 ` Kari Argillander
2022-05-06 5:28 ` Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnStAT+Mudy1xslV@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.