From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Ido Schimmel <idosch@mellanox.com>,
netdev <netdev@vger.kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>
Subject: Re: [Bridge] [PATCH RFC] net: bridge: Clear offload_fwd_mark when passing frame up bridge interface.
Date: Fri, 6 May 2022 18:58:41 +0200 [thread overview]
Message-ID: <YnVTwbPH8YU4kciG@lunn.ch> (raw)
In-Reply-To: <20220506143644.mzfffht44t3glwci@skbuf>
> Some safer alternatives to this patch are based on the idea that we
> could ignore skb->offload_fwd_mark coming from an unoffloaded bridge
> port (i.e. treat this condition at br1, not at br0). We could:
> - clear skb->offload_fwd_mark in br_handle_frame_finish(), if p->hwdom is 0
> - change nbp_switchdev_allowed_egress() to return true if cb->src_hwdom == 0
O.K, i will try out these solutions.
Thanks
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev <netdev@vger.kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@mellanox.com>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>
Subject: Re: [PATCH RFC] net: bridge: Clear offload_fwd_mark when passing frame up bridge interface.
Date: Fri, 6 May 2022 18:58:41 +0200 [thread overview]
Message-ID: <YnVTwbPH8YU4kciG@lunn.ch> (raw)
In-Reply-To: <20220506143644.mzfffht44t3glwci@skbuf>
> Some safer alternatives to this patch are based on the idea that we
> could ignore skb->offload_fwd_mark coming from an unoffloaded bridge
> port (i.e. treat this condition at br1, not at br0). We could:
> - clear skb->offload_fwd_mark in br_handle_frame_finish(), if p->hwdom is 0
> - change nbp_switchdev_allowed_egress() to return true if cb->src_hwdom == 0
O.K, i will try out these solutions.
Thanks
Andrew
next prev parent reply other threads:[~2022-05-06 16:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 22:59 [Bridge] [PATCH RFC] net: bridge: Clear offload_fwd_mark when passing frame up bridge interface Andrew Lunn
2022-05-05 22:59 ` Andrew Lunn
2022-05-05 23:07 ` [Bridge] " Stephen Hemminger
2022-05-05 23:07 ` Stephen Hemminger
2022-05-06 1:18 ` [Bridge] " Andrew Lunn
2022-05-06 1:18 ` Andrew Lunn
2022-05-06 15:05 ` [Bridge] " Stephen Hemminger
2022-05-06 15:05 ` Stephen Hemminger
2022-05-06 14:36 ` [Bridge] " Vladimir Oltean
2022-05-06 14:36 ` Vladimir Oltean
2022-05-06 16:58 ` Andrew Lunn [this message]
2022-05-06 16:58 ` Andrew Lunn
2022-05-08 7:52 ` [Bridge] " Ido Schimmel
2022-05-08 7:52 ` Ido Schimmel
2022-05-12 20:38 ` [Bridge] " Andrew Lunn
2022-05-12 20:38 ` Andrew Lunn
2022-05-13 12:47 ` [Bridge] " Ido Schimmel
2022-05-13 12:47 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnVTwbPH8YU4kciG@lunn.ch \
--to=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.