[f2fs-dev] [PATCH] f2fs: skip GC if possible when checkpoint disabling

[f2fs-dev] [PATCH] f2fs: skip GC if possible when checkpoint disabling

[Weichao Guo]

From: Weichao Guo <guoweichao@oppo.com>

If the number of unusable blocks is not larger than
unusable capacity, we can skip GC when checkpoint
disabling.

Signed-off-by: Weichao Guo <guoweichao@oppo.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/super.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index d06a577..7edb018 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2069,6 +2069,11 @@ static int f2fs_disable_checkpoint(struct f2fs_sb_info *sbi)
 	}
 	sbi->sb->s_flags |= SB_ACTIVE;
 
+	/* check if we need more GC first */
+	unusable = f2fs_get_unusable_blocks(sbi);
+	if (!f2fs_disable_cp_again(sbi, unusable))
+		goto skip_gc;
+
 	f2fs_update_time(sbi, DISABLE_TIME);
 
 	gc_mode = sbi->gc_mode;
@@ -2097,6 +2102,7 @@ static int f2fs_disable_checkpoint(struct f2fs_sb_info *sbi)
 		goto restore_flag;
 	}
 
+skip_gc:
 	f2fs_down_write(&sbi->gc_lock);
 	cpc.reason = CP_PAUSE;
 	set_sbi_flag(sbi, SBI_CP_DISABLED);
-- 
1.9.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: skip GC if possible when checkpoint disabling

[Jaegeuk Kim]

On 05/07, Weichao Guo wrote:
> From: Weichao Guo <guoweichao@oppo.com>
> 
> If the number of unusable blocks is not larger than
> unusable capacity, we can skip GC when checkpoint
> disabling.

I modified to fix restoring gc_mode back by the below.

-       unsigned int gc_mode;
+       unsigned int gc_mode = sbi->gc_mode;


> 
> Signed-off-by: Weichao Guo <guoweichao@oppo.com>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
>  fs/f2fs/super.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index d06a577..7edb018 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2069,6 +2069,11 @@ static int f2fs_disable_checkpoint(struct f2fs_sb_info *sbi)
>  	}
>  	sbi->sb->s_flags |= SB_ACTIVE;
>  
> +	/* check if we need more GC first */
> +	unusable = f2fs_get_unusable_blocks(sbi);
> +	if (!f2fs_disable_cp_again(sbi, unusable))
> +		goto skip_gc;
> +
>  	f2fs_update_time(sbi, DISABLE_TIME);
>  
>  	gc_mode = sbi->gc_mode;
> @@ -2097,6 +2102,7 @@ static int f2fs_disable_checkpoint(struct f2fs_sb_info *sbi)
>  		goto restore_flag;
>  	}
>  
> +skip_gc:
>  	f2fs_down_write(&sbi->gc_lock);
>  	cpc.reason = CP_PAUSE;
>  	set_sbi_flag(sbi, SBI_CP_DISABLED);
> -- 
> 1.9.1


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: skip GC if possible when checkpoint disabling

[Chao Yu]

On 2022/5/7 7:38, Jaegeuk Kim wrote:
> On 05/07, Weichao Guo wrote:
>> From: Weichao Guo <guoweichao@oppo.com>
>>
>> If the number of unusable blocks is not larger than
>> unusable capacity, we can skip GC when checkpoint
>> disabling.
> 
> I modified to fix restoring gc_mode back by the below.
> 
> -       unsigned int gc_mode;
> +       unsigned int gc_mode = sbi->gc_mode;
> 
> 
>>
>> Signed-off-by: Weichao Guo <guoweichao@oppo.com>
>> Signed-off-by: Chao Yu <chao@kernel.org>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel