From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Puyou Lu <puyou.lu@gmail.com>, Andy Shevchenko <andy@kernel.org>,
Kees Cook <keescook@chromium.org>, Petr Mladek <pmladek@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Chris Down <chris@chrisdown.name>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.
Date: Sun, 8 May 2022 13:20:53 +0300 [thread overview]
Message-ID: <YneZhStpXcIFppPs@smile.fi.intel.com> (raw)
In-Reply-To: <20220507114516.5de49b46cf5349db7121eff8@linux-foundation.org>
On Sat, May 07, 2022 at 11:45:16AM -0700, Andrew Morton wrote:
> On Fri, 6 May 2022 15:36:22 +0800 Puyou Lu <puyou.lu@gmail.com> wrote:
>
> > Add allocated strarray to device's resource list. This is a must to
> > automatically release strarray when the device disappears.
>
> So at present we have a memory leak?
Yes.
> Is this likely to be serious enough to justify backporting the fix into
> -stable kernels?
I think so, however there are only few drivers are using it, hence it's
serious, but rare.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-05-08 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 7:36 [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list Puyou Lu
2022-05-06 8:12 ` Andy Shevchenko
2022-05-07 18:45 ` Andrew Morton
2022-05-08 10:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YneZhStpXcIFppPs@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=chris@chrisdown.name \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pmladek@suse.com \
--cc=puyou.lu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.