* [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.
@ 2022-05-06 7:36 Puyou Lu
2022-05-06 8:12 ` Andy Shevchenko
2022-05-07 18:45 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Puyou Lu @ 2022-05-06 7:36 UTC (permalink / raw)
Cc: Puyou Lu, Andy Shevchenko, Andrew Morton, Kees Cook, Petr Mladek,
Linus Walleij, Guenter Roeck, Chris Down, linux-kernel
Add allocated strarray to device's resource list. This is a must to
automatically release strarray when the device disappears.
Fixes: acdb89b6c87a ("lib/string_helpers: Introduce managed variant of kasprintf_strarray()")
Signed-off-by: Puyou Lu <puyou.lu@gmail.com>
---
Change since v1:
also set 'n' of strarray https://lore.kernel.org/lkml/20220506022845.26750-1-puyou.lu@gmail.com/
---
lib/string_helpers.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index 4f877e9551d5..5ed3beb066e6 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n)
return ERR_PTR(-ENOMEM);
}
+ ptr->n = n;
+ devres_add(dev, ptr);
+
return ptr->array;
}
EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.
2022-05-06 7:36 [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list Puyou Lu
@ 2022-05-06 8:12 ` Andy Shevchenko
2022-05-07 18:45 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-05-06 8:12 UTC (permalink / raw)
To: Puyou Lu
Cc: Andy Shevchenko, Andrew Morton, Kees Cook, Petr Mladek,
Linus Walleij, Guenter Roeck, Chris Down, linux-kernel
On Fri, May 6, 2022 at 9:36 AM Puyou Lu <puyou.lu@gmail.com> wrote:
>
> Add allocated strarray to device's resource list. This is a must to
> automatically release strarray when the device disappears.
LGTM,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks!
> Fixes: acdb89b6c87a ("lib/string_helpers: Introduce managed variant of kasprintf_strarray()")
> Signed-off-by: Puyou Lu <puyou.lu@gmail.com>
>
> ---
>
> Change since v1:
> also set 'n' of strarray https://lore.kernel.org/lkml/20220506022845.26750-1-puyou.lu@gmail.com/
>
> ---
> lib/string_helpers.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/string_helpers.c b/lib/string_helpers.c
> index 4f877e9551d5..5ed3beb066e6 100644
> --- a/lib/string_helpers.c
> +++ b/lib/string_helpers.c
> @@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n)
> return ERR_PTR(-ENOMEM);
> }
>
> + ptr->n = n;
> + devres_add(dev, ptr);
> +
> return ptr->array;
> }
> EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.
2022-05-06 7:36 [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list Puyou Lu
2022-05-06 8:12 ` Andy Shevchenko
@ 2022-05-07 18:45 ` Andrew Morton
2022-05-08 10:20 ` Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2022-05-07 18:45 UTC (permalink / raw)
To: Puyou Lu
Cc: Andy Shevchenko, Kees Cook, Petr Mladek, Linus Walleij,
Guenter Roeck, Chris Down, linux-kernel
On Fri, 6 May 2022 15:36:22 +0800 Puyou Lu <puyou.lu@gmail.com> wrote:
> Add allocated strarray to device's resource list. This is a must to
> automatically release strarray when the device disappears.
So at present we have a memory leak?
Is this likely to be serious enough to justify backporting the fix into
-stable kernels?
> --- a/lib/string_helpers.c
> +++ b/lib/string_helpers.c
> @@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n)
> return ERR_PTR(-ENOMEM);
> }
>
> + ptr->n = n;
> + devres_add(dev, ptr);
> +
> return ptr->array;
> }
> EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.
2022-05-07 18:45 ` Andrew Morton
@ 2022-05-08 10:20 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-05-08 10:20 UTC (permalink / raw)
To: Andrew Morton
Cc: Puyou Lu, Andy Shevchenko, Kees Cook, Petr Mladek, Linus Walleij,
Guenter Roeck, Chris Down, linux-kernel
On Sat, May 07, 2022 at 11:45:16AM -0700, Andrew Morton wrote:
> On Fri, 6 May 2022 15:36:22 +0800 Puyou Lu <puyou.lu@gmail.com> wrote:
>
> > Add allocated strarray to device's resource list. This is a must to
> > automatically release strarray when the device disappears.
>
> So at present we have a memory leak?
Yes.
> Is this likely to be serious enough to justify backporting the fix into
> -stable kernels?
I think so, however there are only few drivers are using it, hence it's
serious, but rare.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-08 10:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-06 7:36 [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list Puyou Lu
2022-05-06 8:12 ` Andy Shevchenko
2022-05-07 18:45 ` Andrew Morton
2022-05-08 10:20 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.