From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Sandy Huang <hjc@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
krzk+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2
Date: Tue, 10 May 2022 12:20:39 -0500 [thread overview]
Message-ID: <Ynqe5zcWZw8KJMl1@robh.at.kernel.org> (raw)
In-Reply-To: <3353209.QJadu78ljV@diego>
On Tue, May 10, 2022 at 04:08:02PM +0200, Heiko Stübner wrote:
> Hi Sascha,
>
> Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer:
> > The VOP2 driver relies on reg-names properties, but these are not
> > documented. Add the missing documentation, make reg-names mandatory
> > and increase minItems to 2 as always both register spaces are needed.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> I'm not sure how the DT-people work - if they only track the devicetree list
> or their x+dt@kernel.org accounts or some mixture, but the patch was
> missing the maintainer email addresses - I've added them here now :-) .
I only see what is in DT PW. Since I'm copied on almost everything that
goes to the DT list, CC'ing me has almost no effect.
> The change looks good to me and as I merged the original binding
> into drm-misc only some days ago, we also don't have a backwards-
> compat issue yet, so hopefully DT-people will think similarly .
It will fail checks... I can't run them as this doesn't apply, so
hopefully someone does. Or I can complain when next breaks.
Rob
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Sandy Huang <hjc@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
krzk+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2
Date: Tue, 10 May 2022 12:20:39 -0500 [thread overview]
Message-ID: <Ynqe5zcWZw8KJMl1@robh.at.kernel.org> (raw)
In-Reply-To: <3353209.QJadu78ljV@diego>
On Tue, May 10, 2022 at 04:08:02PM +0200, Heiko Stübner wrote:
> Hi Sascha,
>
> Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer:
> > The VOP2 driver relies on reg-names properties, but these are not
> > documented. Add the missing documentation, make reg-names mandatory
> > and increase minItems to 2 as always both register spaces are needed.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> I'm not sure how the DT-people work - if they only track the devicetree list
> or their x+dt@kernel.org accounts or some mixture, but the patch was
> missing the maintainer email addresses - I've added them here now :-) .
I only see what is in DT PW. Since I'm copied on almost everything that
goes to the DT list, CC'ing me has almost no effect.
> The change looks good to me and as I merged the original binding
> into drm-misc only some days ago, we also don't have a backwards-
> compat issue yet, so hopefully DT-people will think similarly .
It will fail checks... I can't run them as this doesn't apply, so
hopefully someone does. Or I can complain when next breaks.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Sandy Huang <hjc@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
krzk+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2
Date: Tue, 10 May 2022 12:20:39 -0500 [thread overview]
Message-ID: <Ynqe5zcWZw8KJMl1@robh.at.kernel.org> (raw)
In-Reply-To: <3353209.QJadu78ljV@diego>
On Tue, May 10, 2022 at 04:08:02PM +0200, Heiko Stübner wrote:
> Hi Sascha,
>
> Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer:
> > The VOP2 driver relies on reg-names properties, but these are not
> > documented. Add the missing documentation, make reg-names mandatory
> > and increase minItems to 2 as always both register spaces are needed.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> I'm not sure how the DT-people work - if they only track the devicetree list
> or their x+dt@kernel.org accounts or some mixture, but the patch was
> missing the maintainer email addresses - I've added them here now :-) .
I only see what is in DT PW. Since I'm copied on almost everything that
goes to the DT list, CC'ing me has almost no effect.
> The change looks good to me and as I merged the original binding
> into drm-misc only some days ago, we also don't have a backwards-
> compat issue yet, so hopefully DT-people will think similarly .
It will fail checks... I can't run them as this doesn't apply, so
hopefully someone does. Or I can complain when next breaks.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: devicetree@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Peter Geis <pgwipeout@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Michael Riesch <michael.riesch@wolfvision.net>,
kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2
Date: Tue, 10 May 2022 12:20:39 -0500 [thread overview]
Message-ID: <Ynqe5zcWZw8KJMl1@robh.at.kernel.org> (raw)
In-Reply-To: <3353209.QJadu78ljV@diego>
On Tue, May 10, 2022 at 04:08:02PM +0200, Heiko Stübner wrote:
> Hi Sascha,
>
> Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer:
> > The VOP2 driver relies on reg-names properties, but these are not
> > documented. Add the missing documentation, make reg-names mandatory
> > and increase minItems to 2 as always both register spaces are needed.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> I'm not sure how the DT-people work - if they only track the devicetree list
> or their x+dt@kernel.org accounts or some mixture, but the patch was
> missing the maintainer email addresses - I've added them here now :-) .
I only see what is in DT PW. Since I'm copied on almost everything that
goes to the DT list, CC'ing me has almost no effect.
> The change looks good to me and as I merged the original binding
> into drm-misc only some days ago, we also don't have a backwards-
> compat issue yet, so hopefully DT-people will think similarly .
It will fail checks... I can't run them as this doesn't apply, so
hopefully someone does. Or I can complain when next breaks.
Rob
next prev parent reply other threads:[~2022-05-10 17:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 7:09 [PATCH 0/3] RK356x VOP2: Change register space names Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 14:08 ` Heiko Stübner
2022-05-10 14:08 ` Heiko Stübner
2022-05-10 14:08 ` Heiko Stübner
2022-05-10 14:08 ` Heiko Stübner
2022-05-10 17:20 ` Rob Herring [this message]
2022-05-10 17:20 ` Rob Herring
2022-05-10 17:20 ` Rob Herring
2022-05-10 17:20 ` Rob Herring
2022-05-10 17:15 ` Rob Herring
2022-05-10 17:15 ` Rob Herring
2022-05-10 17:15 ` Rob Herring
2022-05-10 17:15 ` Rob Herring
2022-05-11 8:10 ` Sascha Hauer
2022-05-11 8:10 ` Sascha Hauer
2022-05-11 8:10 ` Sascha Hauer
2022-05-11 8:10 ` Sascha Hauer
2022-05-10 7:09 ` [PATCH 2/3] drm: rockchip: Change register space names Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` [PATCH 3/3] arm64: dts: rockchip: rk356x: Change VOP2 " Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
2022-05-10 7:09 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynqe5zcWZw8KJMl1@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.