From: Rob Herring <robh@kernel.org>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Michael Turquette <mturquette@baylibre.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st,stm32mp1-rcc-secure"
Date: Tue, 10 May 2022 13:22:21 -0500 [thread overview]
Message-ID: <YnqtXa+NhVUH0oyi@robh.at.kernel.org> (raw)
In-Reply-To: <b64e6662-5fd2-5223-1e25-15217d75d06a@foss.st.com>
On Tue, May 10, 2022 at 06:44:19PM +0200, Alexandre TORGUE wrote:
> Hi Rob
>
> On 5/10/22 16:57, Rob Herring wrote:
> > On Tue, May 10, 2022 at 09:47:05AM +0200, Alexandre TORGUE wrote:
> > > Hi Rob
> > >
> > > On 5/9/22 21:16, Rob Herring wrote:
> > > > On Mon, 09 May 2022 15:46:58 +0200, Alexandre Torgue wrote:
> > > > > For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
> > > > > required properties.
> > > > >
> > > > > Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> > > > >
> > > >
> > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > >
> > > > yamllint warnings/errors:
> > > >
> > > > dtschema/dtc warnings/errors:
> > > > Error: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts:27.33-34 syntax error
> > > > FATAL ERROR: Unable to parse input tree
> > > > make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb] Error 1
> > > > make[1]: *** Waiting for unfinished jobs....
> > > > make: *** [Makefile:1401: dt_binding_check] Error 2
> > > >
> > > > doc reference errors (make refcheckdocs):
> > > >
> > > > See https://patchwork.ozlabs.org/patch/
> > > >
> > > > This check can fail if there are any dependencies. The base for a patch
> > > > series is generally the most recent rc1.
> > > >
> > > > If you already ran 'make dt_binding_check' and didn't see the above
> > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > > date:
> > > >
> > > > pip3 install dtschema --upgrade
> > > >
> > > > Please check and re-submit.
> > > >
> > >
> > > I just updated dtschema and yamllint seems to be well installed. I don't see
> > > the see above. I wrote this patch on top of my stm32-next tree. Do I have to
> > > send it directly to arm-soc in order to be merged on top of my latest
> > > pull-request ?
> >
> > That appears to be header related AFAICT. Maybe you have header changes
> > in your tree. The issue this is fixing is in your tree, so it should be
> > applied there.
>
> Ah yes! CK_SCMIxxx have changed in my tree (merged in arm-soc tree) and this
> patch is done on top of this change. So has to be applied in arm-soc.
> So I just have to send it directly to Arnd and arm-soc ?
If you don't have a fixes branch for them (or one that will be pulled
soonish), then yes.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Michael Turquette <mturquette@baylibre.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st,stm32mp1-rcc-secure"
Date: Tue, 10 May 2022 13:22:21 -0500 [thread overview]
Message-ID: <YnqtXa+NhVUH0oyi@robh.at.kernel.org> (raw)
In-Reply-To: <b64e6662-5fd2-5223-1e25-15217d75d06a@foss.st.com>
On Tue, May 10, 2022 at 06:44:19PM +0200, Alexandre TORGUE wrote:
> Hi Rob
>
> On 5/10/22 16:57, Rob Herring wrote:
> > On Tue, May 10, 2022 at 09:47:05AM +0200, Alexandre TORGUE wrote:
> > > Hi Rob
> > >
> > > On 5/9/22 21:16, Rob Herring wrote:
> > > > On Mon, 09 May 2022 15:46:58 +0200, Alexandre Torgue wrote:
> > > > > For "st,stm32mp1-rcc-secure" schema, clocks and clock-names entries are now
> > > > > required properties.
> > > > >
> > > > > Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> > > > >
> > > >
> > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > >
> > > > yamllint warnings/errors:
> > > >
> > > > dtschema/dtc warnings/errors:
> > > > Error: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dts:27.33-34 syntax error
> > > > FATAL ERROR: Unable to parse input tree
> > > > make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.example.dtb] Error 1
> > > > make[1]: *** Waiting for unfinished jobs....
> > > > make: *** [Makefile:1401: dt_binding_check] Error 2
> > > >
> > > > doc reference errors (make refcheckdocs):
> > > >
> > > > See https://patchwork.ozlabs.org/patch/
> > > >
> > > > This check can fail if there are any dependencies. The base for a patch
> > > > series is generally the most recent rc1.
> > > >
> > > > If you already ran 'make dt_binding_check' and didn't see the above
> > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > > date:
> > > >
> > > > pip3 install dtschema --upgrade
> > > >
> > > > Please check and re-submit.
> > > >
> > >
> > > I just updated dtschema and yamllint seems to be well installed. I don't see
> > > the see above. I wrote this patch on top of my stm32-next tree. Do I have to
> > > send it directly to arm-soc in order to be merged on top of my latest
> > > pull-request ?
> >
> > That appears to be header related AFAICT. Maybe you have header changes
> > in your tree. The issue this is fixing is in your tree, so it should be
> > applied there.
>
> Ah yes! CK_SCMIxxx have changed in my tree (merged in arm-soc tree) and this
> patch is done on top of this change. So has to be applied in arm-soc.
> So I just have to send it directly to Arnd and arm-soc ?
If you don't have a fixes branch for them (or one that will be pulled
soonish), then yes.
Rob
next prev parent reply other threads:[~2022-05-10 18:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 13:46 [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st, stm32mp1-rcc-secure" Alexandre Torgue
2022-05-09 13:46 ` [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st,stm32mp1-rcc-secure" Alexandre Torgue
2022-05-09 19:16 ` [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st, stm32mp1-rcc-secure" Rob Herring
2022-05-09 19:16 ` [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st,stm32mp1-rcc-secure" Rob Herring
2022-05-10 7:47 ` Alexandre TORGUE
2022-05-10 7:47 ` Alexandre TORGUE
2022-05-10 14:57 ` Rob Herring
2022-05-10 14:57 ` Rob Herring
2022-05-10 16:44 ` Alexandre TORGUE
2022-05-10 16:44 ` Alexandre TORGUE
2022-05-10 18:22 ` Rob Herring [this message]
2022-05-10 18:22 ` Rob Herring
2022-05-10 18:23 ` Rob Herring
2022-05-10 18:23 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2022-05-11 9:25 Alexandre Torgue
2022-05-11 9:25 ` [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st, stm32mp1-rcc-secure" Alexandre Torgue
2022-05-13 10:00 ` [PATCH] dt-bindings: clock: stm32mp1: adapt example for "st,stm32mp1-rcc-secure" patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnqtXa+NhVUH0oyi@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.