From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Chen Wandun <chenwandun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] psi: dont alloc memory for psi by default
Date: Thu, 26 May 2022 12:10:05 -0400 [thread overview]
Message-ID: <Yo+mXVefsRSxjTMY@cmpxchg.org> (raw)
In-Reply-To: <20220526122656.256274-1-chenwandun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Thu, May 26, 2022 at 08:26:56PM +0800, Chen Wandun wrote:
> Memory about struct psi_group is allocated by default for
> each cgroup even if psi_disabled is true, in this case, these
> allocated memory is waste, so alloc memory for struct psi_group
> only when psi_disabled is false.
>
> Signed-off-by: Chen Wandun <chenwandun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Looks good to me,
Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Tejun, would you mind taking this through the cgroup tree?
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Chen Wandun <chenwandun@huawei.com>
Cc: tj@kernel.org, lizefan.x@bytedance.com, surenb@google.com,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] psi: dont alloc memory for psi by default
Date: Thu, 26 May 2022 12:10:05 -0400 [thread overview]
Message-ID: <Yo+mXVefsRSxjTMY@cmpxchg.org> (raw)
In-Reply-To: <20220526122656.256274-1-chenwandun@huawei.com>
On Thu, May 26, 2022 at 08:26:56PM +0800, Chen Wandun wrote:
> Memory about struct psi_group is allocated by default for
> each cgroup even if psi_disabled is true, in this case, these
> allocated memory is waste, so alloc memory for struct psi_group
> only when psi_disabled is false.
>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Looks good to me,
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Tejun, would you mind taking this through the cgroup tree?
next prev parent reply other threads:[~2022-05-26 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 12:26 [PATCH] psi: dont alloc memory for psi by default Chen Wandun
2022-05-26 12:26 ` Chen Wandun
[not found] ` <20220526122656.256274-1-chenwandun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-05-26 16:10 ` Johannes Weiner [this message]
2022-05-26 16:10 ` Johannes Weiner
[not found] ` <Yo+mXVefsRSxjTMY-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-05-26 18:54 ` Tejun Heo
2022-05-26 18:54 ` Tejun Heo
2022-06-07 17:12 ` Tejun Heo
2022-06-07 17:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo+mXVefsRSxjTMY@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=chenwandun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.