All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Ben Brown <ben@demerara.io>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] build: Fix error during out of tree build
Date: Wed, 25 May 2022 13:04:25 +0200	[thread overview]
Message-ID: <Yo4NOcCsPPCM5h+6@orbyte.nwl.cc> (raw)
In-Reply-To: <d454c825-2d43-56d9-d001-e98308d2dd1b@demerara.io>

On Thu, May 19, 2022 at 07:07:23PM +0100, Ben Brown wrote:
> From a7a2f49a53ce5487a9869cd44b647de0882c6996 Mon Sep 17 00:00:00 2001
> From: Ben Brown <ben@demerara.io>
> Date: Thu, 19 May 2022 18:50:25 +0100
> Subject: [PATCH] build: Fix error during out of tree build
> 
> Fixes the following error:
> 
>     ../../libxtables/xtables.c:52:10: fatal error: libiptc/linux_list.h:
> No such file or directory
>        52 | #include <libiptc/linux_list.h>
> 
> Signed-off-by: Ben Brown <ben@demerara.io>

Your mailer broke the patch by breaking long lines. Please use
git-send-email to submit patches, it's a lot less error-prone.

When resubmitting, also please add:

Fixes: f58b0d7406451 ("libxtables: Implement notargets hash table")

Apart from that, looks good to me!

Thanks, Phil

  reply	other threads:[~2022-05-25 11:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 18:07 [iptables PATCH] build: Fix error during out of tree build Ben Brown
2022-05-25 11:04 ` Phil Sutter [this message]
2022-05-25 15:21   ` Ben Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yo4NOcCsPPCM5h+6@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=ben@demerara.io \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.