[iptables PATCH] build: Fix error during out of tree build

[iptables PATCH] build: Fix error during out of tree build

[Ben Brown]

From a7a2f49a53ce5487a9869cd44b647de0882c6996 Mon Sep 17 00:00:00 2001
From: Ben Brown <ben@demerara.io>
Date: Thu, 19 May 2022 18:50:25 +0100
Subject: [PATCH] build: Fix error during out of tree build

Fixes the following error:

    ../../libxtables/xtables.c:52:10: fatal error: libiptc/linux_list.h:
No such file or directory
       52 | #include <libiptc/linux_list.h>

Signed-off-by: Ben Brown <ben@demerara.io>
---
 libxtables/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libxtables/Makefile.am b/libxtables/Makefile.am
index 8ff6b0ca..3bfded85 100644
--- a/libxtables/Makefile.am
+++ b/libxtables/Makefile.am
@@ -1,7 +1,7 @@
 # -*- Makefile -*-

 AM_CFLAGS   = ${regular_CFLAGS}
-AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include
-I${top_srcdir}/include -I${top_srcdir}/iptables ${kinclude_CPPFLAGS}
+AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include
-I${top_srcdir}/include -I${top_srcdir}/iptables -I${top_srcdir}
${kinclude_CPPFLAGS}

 lib_LTLIBRARIES       = libxtables.la
 libxtables_la_SOURCES = xtables.c xtoptions.c getethertype.c
-- 
2.36.1

Re: [iptables PATCH] build: Fix error during out of tree build

[Phil Sutter]

On Thu, May 19, 2022 at 07:07:23PM +0100, Ben Brown wrote:
> From a7a2f49a53ce5487a9869cd44b647de0882c6996 Mon Sep 17 00:00:00 2001
> From: Ben Brown <ben@demerara.io>
> Date: Thu, 19 May 2022 18:50:25 +0100
> Subject: [PATCH] build: Fix error during out of tree build
> 
> Fixes the following error:
> 
>     ../../libxtables/xtables.c:52:10: fatal error: libiptc/linux_list.h:
> No such file or directory
>        52 | #include <libiptc/linux_list.h>
> 
> Signed-off-by: Ben Brown <ben@demerara.io>

Your mailer broke the patch by breaking long lines. Please use
git-send-email to submit patches, it's a lot less error-prone.

When resubmitting, also please add:

Fixes: f58b0d7406451 ("libxtables: Implement notargets hash table")

Apart from that, looks good to me!

Thanks, Phil

Re: [iptables PATCH] build: Fix error during out of tree build

[Ben Brown]

On 25/05/2022 12:04, Phil Sutter wrote:
> Your mailer broke the patch by breaking long lines. Please use
> git-send-email to submit patches, it's a lot less error-prone.

Erk, apologies. I was attempting to circumvent having to update my
sendemail configs, though clearly that wasn't the smart choice.

> When resubmitting, also please add:
> 
> Fixes: f58b0d7406451 ("libxtables: Implement notargets hash table")

Sure thing!

> Apart from that, looks good to me!

Cheers,
Ben