From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: linaro-mm-sig@lists.linaro.org,
"Christian König" <christian.koenig@amd.com>,
sumit.semwal@linaro.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] dma-buf: cleanup dma_fence_chain_walk
Date: Wed, 25 May 2022 17:18:42 +0200 [thread overview]
Message-ID: <Yo5I0otoyJsHY0dk@phenom.ffwll.local> (raw)
In-Reply-To: <20220518085446.31338-1-christian.koenig@amd.com>
On Wed, May 18, 2022 at 10:54:46AM +0200, Christian König wrote:
> Use unrcu_pointer() instead of the manual cast.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
TIL about unrcu_pointer, and also that entire code here freaks me out. But
at least this seems more with what other users of similar xchg and cmpxchg
tricks are doing, so that's nice.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/dma-buf/dma-fence-chain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c
> index 06f8ef97c6e8..a0d920576ba6 100644
> --- a/drivers/dma-buf/dma-fence-chain.c
> +++ b/drivers/dma-buf/dma-fence-chain.c
> @@ -62,8 +62,8 @@ struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence)
> replacement = NULL;
> }
>
> - tmp = cmpxchg((struct dma_fence __force **)&chain->prev,
> - prev, replacement);
> + tmp = unrcu_pointer(cmpxchg(&chain->prev, RCU_INITIALIZER(prev),
> + RCU_INITIALIZER(replacement)));
> if (tmp == prev)
> dma_fence_put(tmp);
> else
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: sumit.semwal@linaro.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] dma-buf: cleanup dma_fence_chain_walk
Date: Wed, 25 May 2022 17:18:42 +0200 [thread overview]
Message-ID: <Yo5I0otoyJsHY0dk@phenom.ffwll.local> (raw)
In-Reply-To: <20220518085446.31338-1-christian.koenig@amd.com>
On Wed, May 18, 2022 at 10:54:46AM +0200, Christian König wrote:
> Use unrcu_pointer() instead of the manual cast.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
TIL about unrcu_pointer, and also that entire code here freaks me out. But
at least this seems more with what other users of similar xchg and cmpxchg
tricks are doing, so that's nice.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/dma-buf/dma-fence-chain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c
> index 06f8ef97c6e8..a0d920576ba6 100644
> --- a/drivers/dma-buf/dma-fence-chain.c
> +++ b/drivers/dma-buf/dma-fence-chain.c
> @@ -62,8 +62,8 @@ struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence)
> replacement = NULL;
> }
>
> - tmp = cmpxchg((struct dma_fence __force **)&chain->prev,
> - prev, replacement);
> + tmp = unrcu_pointer(cmpxchg(&chain->prev, RCU_INITIALIZER(prev),
> + RCU_INITIALIZER(replacement)));
> if (tmp == prev)
> dma_fence_put(tmp);
> else
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2022-05-25 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 8:54 [PATCH] dma-buf: cleanup dma_fence_chain_walk Christian König
2022-05-25 15:18 ` Daniel Vetter [this message]
2022-05-25 15:18 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo5I0otoyJsHY0dk@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=christian.koenig@amd.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.