From: Matthias Kaehlcke <mka@chromium.org>
To: Judy Hsiao <judyhsiao@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
dianders@chromium.org, cychiang@google.com, judyhsiao@google.com,
tzungbi@chromium.org, swboyd@chromium.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v3 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
Date: Wed, 25 May 2022 08:25:59 -0700 [thread overview]
Message-ID: <Yo5Kh1/nBBj6B81J@google.com> (raw)
In-Reply-To: <20220525014308.1853576-2-judyhsiao@chromium.org>
On Wed, May 25, 2022 at 01:43:06AM +0000, Judy Hsiao wrote:
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disable the pull-up for mi2s1 lines.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
You already had my 'Reviewed-by' tag for version 1 and 2, please make
sure to include these tags when you post a new version (unless there
are significant changes). That way maintainers can see that a patch
has been reviewed previously, without having to go through the entire
patch history, which they are unlikely to do. And your reviewer don't
want to be burdened either with having to send the tags over and over
again :)
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Judy Hsiao <judyhsiao@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
dianders@chromium.org, cychiang@google.com, judyhsiao@google.com,
tzungbi@chromium.org, swboyd@chromium.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v3 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
Date: Wed, 25 May 2022 08:25:59 -0700 [thread overview]
Message-ID: <Yo5Kh1/nBBj6B81J@google.com> (raw)
In-Reply-To: <20220525014308.1853576-2-judyhsiao@chromium.org>
On Wed, May 25, 2022 at 01:43:06AM +0000, Judy Hsiao wrote:
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disable the pull-up for mi2s1 lines.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
You already had my 'Reviewed-by' tag for version 1 and 2, please make
sure to include these tags when you post a new version (unless there
are significant changes). That way maintainers can see that a patch
has been reviewed previously, without having to go through the entire
patch history, which they are unlikely to do. And your reviewer don't
want to be burdened either with having to send the tags over and over
again :)
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-25 15:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 1:43 [v3 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec Judy Hsiao
2022-05-25 1:43 ` Judy Hsiao
2022-05-25 1:43 ` [v3 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 Judy Hsiao
2022-05-25 1:43 ` Judy Hsiao
2022-05-25 15:25 ` Matthias Kaehlcke [this message]
2022-05-25 15:25 ` Matthias Kaehlcke
2022-05-25 17:50 ` Doug Anderson
2022-05-25 17:50 ` Doug Anderson
2022-05-25 1:43 ` [v3 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi Judy Hsiao
2022-05-25 1:43 ` Judy Hsiao
2022-05-25 15:35 ` Matthias Kaehlcke
2022-05-25 15:35 ` Matthias Kaehlcke
2022-05-25 17:50 ` Doug Anderson
2022-05-25 17:50 ` Doug Anderson
2022-05-25 1:43 ` [v3 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 Judy Hsiao
2022-05-25 1:43 ` Judy Hsiao
2022-05-25 15:36 ` Matthias Kaehlcke
2022-05-25 15:36 ` Matthias Kaehlcke
2022-05-25 17:52 ` Doug Anderson
2022-05-25 17:52 ` Doug Anderson
2022-09-13 18:06 ` Matthias Kaehlcke
2022-09-13 18:06 ` Matthias Kaehlcke
2022-06-26 2:50 ` [v3 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec Bjorn Andersson
2022-06-26 2:50 ` Bjorn Andersson
2022-06-27 15:59 ` Matthias Kaehlcke
2022-06-27 15:59 ` Matthias Kaehlcke
2022-10-18 3:05 ` Bjorn Andersson
2022-10-18 3:05 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo5Kh1/nBBj6B81J@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cychiang@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=judyhsiao@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.