All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-media@vger.kernel.org, gushengxian@yulong.com,
	hverkuil-cisco@xs4all.nl, mchehab@kernel.org
Subject: Re: [PATCH 2/2] flexcop: allow for modern speeds
Date: Tue, 17 May 2022 15:23:37 +0200	[thread overview]
Message-ID: <YoOh2TC9RMOjx/ps@hovoldconsulting.com> (raw)
In-Reply-To: <20220517131109.28371-2-oneukum@suse.com>

On Tue, May 17, 2022 at 03:11:09PM +0200, Oliver Neukum wrote:
> High speed is no longer the ultimate in speed.
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>  drivers/media/usb/b2c2/flexcop-usb.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c
> index 98d9912a4efb..52e9964c2e59 100644
> --- a/drivers/media/usb/b2c2/flexcop-usb.c
> +++ b/drivers/media/usb/b2c2/flexcop-usb.c
> @@ -525,6 +525,12 @@ static int flexcop_usb_init(struct flexcop_usb *fc_usb)
>  	case USB_SPEED_HIGH:
>  		info("running at HIGH speed.");
>  		break;
> +	case USB_SPEED_SUPER:
> +		info("running at SUPER speed.");
> +		break;
> +	case USB_SPEED_SUPER_PLUS:
> +		info("running at SUPER+ speed.");
> +		break;

Not sure this change is warranted, though. These devices aren't going to
start supporting SuperSpeed.

>  	case USB_SPEED_UNKNOWN:
>  	default:
>  		err("cannot handle USB speed because it is unknown.");

Johan

  reply	other threads:[~2022-05-17 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 13:11 [PATCH 1/2] flexcop: unneeded ATOMIC Oliver Neukum
2022-05-17 13:11 ` [PATCH 2/2] flexcop: allow for modern speeds Oliver Neukum
2022-05-17 13:23   ` Johan Hovold [this message]
2022-05-17 13:21 ` [PATCH 1/2] flexcop: unneeded ATOMIC Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoOh2TC9RMOjx/ps@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=gushengxian@yulong.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.