Re: [PATCH 1/2] flexcop: unneeded ATOMIC

[Johan Hovold <johan@kernel.org>]

On Tue, May 17, 2022 at 03:11:08PM +0200, Oliver Neukum wrote:
> No need for GFP_ATOMIC during probe()

Please add a "media: " prefix and use a verb (e.g. "replace") in
Subject.

> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>  drivers/media/usb/b2c2/flexcop-usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c
> index 7835bb0f32fc..98d9912a4efb 100644
> --- a/drivers/media/usb/b2c2/flexcop-usb.c
> +++ b/drivers/media/usb/b2c2/flexcop-usb.c
> @@ -446,7 +446,7 @@ static int flexcop_usb_transfer_init(struct flexcop_usb *fc_usb)
>  	/* creating iso urbs */
>  	for (i = 0; i < B2C2_USB_NUM_ISO_URB; i++) {
>  		fc_usb->iso_urb[i] = usb_alloc_urb(B2C2_USB_FRAMES_PER_ISO,
> -			GFP_ATOMIC);
> +			GFP_KERNEL);
>  		if (fc_usb->iso_urb[i] == NULL) {
>  			ret = -ENOMEM;
>  			goto urb_error;
> @@ -479,7 +479,7 @@ static int flexcop_usb_transfer_init(struct flexcop_usb *fc_usb)
>  			frame_offset += frame_size;
>  		}
>  
> -		if ((ret = usb_submit_urb(fc_usb->iso_urb[i],GFP_ATOMIC))) {
> +		if ((ret = usb_submit_urb(fc_usb->iso_urb[i],GFP_KERNEL))) {

And add the missing space after the comma here.

>  			err("submitting urb %d failed with %d.", i, ret);
>  			goto urb_error;
>  		}

Change itself looks good otherwise.

Reviewed-by: Johan Hovold <johan@kernel.org>

Johan