From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: adilger.kernel@dilger.ca, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v4 00/10] Clean up the case-insensitive lookup path
Date: Tue, 17 May 2022 15:37:48 -0400 [thread overview]
Message-ID: <YoP5jH5axe9ltX2Y@mit.edu> (raw)
In-Reply-To: <20220511193146.27526-1-krisman@collabora.com>
On Wed, May 11, 2022 at 03:31:36PM -0400, Gabriel Krisman Bertazi wrote:
> The case-insensitive implementations in f2fs and ext4 have quite a bit
> of duplicated code. This series simplifies the ext4 version, with the
> goal of extracting ext4_ci_compare into a helper library that can be
> used by both filesystems. It also reduces the clutter from many
> codeguards for CONFIG_UNICODE; as requested by Linus, they are part of
> the codeflow now.
>
> While there, I noticed we can leverage the utf8 functions to detect
> encoded names that are corrupted in the filesystem. Therefore, it also
> adds an ext4 error on that scenario, to mark the filesystem as
> corrupted.
Gabriel, are you planning on doing another version of this patch series?
It looks like the first two patches for ext4 are not controversial, so
I could take those, while some of the other patches have questions
which Eric has raised.
Thanks,
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: kernel@collabora.com, linux-f2fs-devel@lists.sourceforge.net,
ebiggers@kernel.org, adilger.kernel@dilger.ca,
jaegeuk@kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v4 00/10] Clean up the case-insensitive lookup path
Date: Tue, 17 May 2022 15:37:48 -0400 [thread overview]
Message-ID: <YoP5jH5axe9ltX2Y@mit.edu> (raw)
In-Reply-To: <20220511193146.27526-1-krisman@collabora.com>
On Wed, May 11, 2022 at 03:31:36PM -0400, Gabriel Krisman Bertazi wrote:
> The case-insensitive implementations in f2fs and ext4 have quite a bit
> of duplicated code. This series simplifies the ext4 version, with the
> goal of extracting ext4_ci_compare into a helper library that can be
> used by both filesystems. It also reduces the clutter from many
> codeguards for CONFIG_UNICODE; as requested by Linus, they are part of
> the codeflow now.
>
> While there, I noticed we can leverage the utf8 functions to detect
> encoded names that are corrupted in the filesystem. Therefore, it also
> adds an ext4 error on that scenario, to mark the filesystem as
> corrupted.
Gabriel, are you planning on doing another version of this patch series?
It looks like the first two patches for ext4 are not controversial, so
I could take those, while some of the other patches have questions
which Eric has raised.
Thanks,
- Ted
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-05-17 19:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 19:31 [PATCH v4 00/10] Clean up the case-insensitive lookup path Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 01/10] ext4: Match the f2fs ci_compare implementation Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 02/10] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 03/10] f2fs: " Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-12 4:49 ` Eric Biggers
2022-05-12 4:49 ` [f2fs-dev] " Eric Biggers
2022-05-11 19:31 ` [PATCH v4 04/10] ext4: Implement ci comparison using unicode_name Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-12 5:35 ` Eric Biggers
2022-05-12 5:35 ` [f2fs-dev] " Eric Biggers
2022-05-11 19:31 ` [PATCH v4 05/10] ext4: Simplify hash check on ext4_match Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-12 5:46 ` Eric Biggers
2022-05-12 5:46 ` [f2fs-dev] " Eric Biggers
2022-05-11 19:31 ` [PATCH v4 06/10] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-12 5:48 ` Eric Biggers
2022-05-12 5:48 ` [f2fs-dev] " Eric Biggers
2022-05-11 19:31 ` [PATCH v4 07/10] ext4: Move ext4_match_ci into libfs Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-12 5:24 ` Eric Biggers
2022-05-12 5:24 ` [f2fs-dev] " Eric Biggers
2022-05-11 19:31 ` [PATCH v4 08/10] f2fs: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-11 19:31 ` [PATCH v4 09/10] ext4: Move CONFIG_UNICODE defguards into the code flow Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-12 4:59 ` Eric Biggers
2022-05-12 4:59 ` [f2fs-dev] " Eric Biggers
2022-05-11 19:31 ` [PATCH v4 10/10] f2fs: " Gabriel Krisman Bertazi
2022-05-11 19:31 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-12 4:55 ` Eric Biggers
2022-05-12 4:55 ` [f2fs-dev] " Eric Biggers
2022-05-17 19:37 ` Theodore Ts'o [this message]
2022-05-17 19:37 ` [f2fs-dev] [PATCH v4 00/10] Clean up the case-insensitive lookup path Theodore Ts'o
2022-05-17 19:57 ` Gabriel Krisman Bertazi
2022-05-17 19:57 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 0:15 ` Theodore Ts'o
2022-05-18 0:15 ` [f2fs-dev] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoP5jH5axe9ltX2Y@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.