All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zenithal <i@zenithal.me>
To: Conor.Dooley@microchip.com
Cc: palmer@rivosinc.com, paul.walmsley@sifive.com,
	aou@eecs.berkeley.edu, heiko@sntech.de, atishp@rivosinc.com,
	anup@brainfault.org, ebiederm@xmission.com,
	keescook@chromium.org, linux-mm@kvack.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, mtk.manpages@gmail.com,
	linux-man@vger.kernel.org, jiatai2021@iscas.ac.cn
Subject: Re: [PATCH -next v2 1/3] RISC-V: add Bitmanip/Scalar Crypto parsing from DT
Date: Wed, 18 May 2022 19:04:28 +0800	[thread overview]
Message-ID: <YoTSvFe56tLy3M+u@Sun> (raw)
In-Reply-To: <3e3891ad-2d31-99a0-bb65-1e6643ff6b96@microchip.com>

On Wed, May 18, 2022 at 09:50:18AM +0000, Conor.Dooley@microchip.com wrote:
> On 18/05/2022 10:25, Hongren (Zenithal) Zheng wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > This commit parses Zb/Zk related string from DT and
> > output them in cpuinfo
> 
> Similarly here, the typical "this patch" comment.

Will fix in the next version.

> 
> > 
> > One thing worth noting is that if DT provides zk,
> > all zbkb, zbkc, zbkx and zkn, zkr, zkt would be enabled.
> > 
> > Note that zk is a valid extension name and the current
> > DT binding spec allows this.
> > 
> > This commit also changes the logical id of
> 
> "also" makes it sound like this a separate change?
> If so, split it into another patch.

No, adding Zba naturally changes the logical id.
I think it would be strange the first patch appends Zba
then the second patch moves Zba to the beginning of the list

> 
> > existing multi-letter extensions and adds a statement
> > that instead of logical id compatibility, the order
> > is needed.
> > 
> > There currently lacks a mechanism to merge them when
> > producing cpuinfo. Namely if you provide a riscv,isa
> > "rv64imafdc_zk_zks", the cpuinfo output would be
> > "rv64imafdc_zbkb_zbkc_zbkx_zknd_zkne_zknh_zkr_zksed
> > _zksh_zkt"
> > 
> > Tested-by: Jiatai He <jiatai2021@iscas.ac.cn>
> > Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>

WARNING: multiple messages have this Message-ID (diff)
From: Zenithal <i@zenithal.me>
To: Conor.Dooley@microchip.com
Cc: palmer@rivosinc.com, paul.walmsley@sifive.com,
	aou@eecs.berkeley.edu, heiko@sntech.de, atishp@rivosinc.com,
	anup@brainfault.org, ebiederm@xmission.com,
	keescook@chromium.org, linux-mm@kvack.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, mtk.manpages@gmail.com,
	linux-man@vger.kernel.org, jiatai2021@iscas.ac.cn
Subject: Re: [PATCH -next v2 1/3] RISC-V: add Bitmanip/Scalar Crypto parsing from DT
Date: Wed, 18 May 2022 19:04:28 +0800	[thread overview]
Message-ID: <YoTSvFe56tLy3M+u@Sun> (raw)
In-Reply-To: <3e3891ad-2d31-99a0-bb65-1e6643ff6b96@microchip.com>

On Wed, May 18, 2022 at 09:50:18AM +0000, Conor.Dooley@microchip.com wrote:
> On 18/05/2022 10:25, Hongren (Zenithal) Zheng wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > This commit parses Zb/Zk related string from DT and
> > output them in cpuinfo
> 
> Similarly here, the typical "this patch" comment.

Will fix in the next version.

> 
> > 
> > One thing worth noting is that if DT provides zk,
> > all zbkb, zbkc, zbkx and zkn, zkr, zkt would be enabled.
> > 
> > Note that zk is a valid extension name and the current
> > DT binding spec allows this.
> > 
> > This commit also changes the logical id of
> 
> "also" makes it sound like this a separate change?
> If so, split it into another patch.

No, adding Zba naturally changes the logical id.
I think it would be strange the first patch appends Zba
then the second patch moves Zba to the beginning of the list

> 
> > existing multi-letter extensions and adds a statement
> > that instead of logical id compatibility, the order
> > is needed.
> > 
> > There currently lacks a mechanism to merge them when
> > producing cpuinfo. Namely if you provide a riscv,isa
> > "rv64imafdc_zk_zks", the cpuinfo output would be
> > "rv64imafdc_zbkb_zbkc_zbkx_zknd_zkne_zknh_zkr_zksed
> > _zksh_zkt"
> > 
> > Tested-by: Jiatai He <jiatai2021@iscas.ac.cn>
> > Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-05-18 11:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  9:21 [PATCH -next v2 0/3] RISC-V: Add Bitmanip/Scalar Crypto HWCAP Hongren (Zenithal) Zheng
2022-05-18  9:21 ` Hongren (Zenithal) Zheng
2022-05-18  9:25 ` [PATCH -next v2 1/3] RISC-V: add Bitmanip/Scalar Crypto parsing from DT Hongren (Zenithal) Zheng
2022-05-18  9:25   ` Hongren (Zenithal) Zheng
2022-05-18  9:50   ` Conor.Dooley
2022-05-18  9:50     ` Conor.Dooley
2022-05-18 11:04     ` Zenithal [this message]
2022-05-18 11:04       ` Zenithal
2022-05-18  9:25 ` [PATCH -next v2 2/3] RISC-V: uapi: add HWCAP for Bitmanip/Scalar Crypto Hongren (Zenithal) Zheng
2022-05-18  9:25   ` Hongren (Zenithal) Zheng
2022-05-18  9:39   ` Conor.Dooley
2022-05-18  9:39     ` Conor.Dooley
2022-05-18 11:00     ` Zenithal
2022-05-18 11:00       ` Zenithal
2022-05-18  9:26 ` [PATCH -next v2 3/3] RISC-V: HWCAP: parse Bitmanip/Scalar Crypto HWCAP from DT Hongren (Zenithal) Zheng
2022-05-18  9:26   ` Hongren (Zenithal) Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoTSvFe56tLy3M+u@Sun \
    --to=i@zenithal.me \
    --cc=Conor.Dooley@microchip.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@rivosinc.com \
    --cc=ebiederm@xmission.com \
    --cc=heiko@sntech.de \
    --cc=jiatai2021@iscas.ac.cn \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mtk.manpages@gmail.com \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.