From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com
Subject: Re: [PATCH v5 8/8] f2fs: Move CONFIG_UNICODE defguards into the code flow
Date: Wed, 18 May 2022 12:26:54 -0700 [thread overview]
Message-ID: <YoVIfsjT2OE6Wj2k@sol.localdomain> (raw)
In-Reply-To: <20220518172320.333617-9-krisman@collabora.com>
On Wed, May 18, 2022 at 01:23:20PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of a bunch of ifdefs, make the unicode built checks part of the
> code flow where possible, as requested by Torvalds.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> ---
> Changes since v4:
> - Drop stub removal for !CONFIG_UNICODE case (eric)
> ---
> fs/f2fs/namei.c | 11 +++++------
> fs/f2fs/super.c | 8 ++++----
> 2 files changed, 9 insertions(+), 10 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu,
linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca,
jaegeuk@kernel.org, kernel@collabora.com
Subject: Re: [f2fs-dev] [PATCH v5 8/8] f2fs: Move CONFIG_UNICODE defguards into the code flow
Date: Wed, 18 May 2022 12:26:54 -0700 [thread overview]
Message-ID: <YoVIfsjT2OE6Wj2k@sol.localdomain> (raw)
In-Reply-To: <20220518172320.333617-9-krisman@collabora.com>
On Wed, May 18, 2022 at 01:23:20PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of a bunch of ifdefs, make the unicode built checks part of the
> code flow where possible, as requested by Torvalds.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> ---
> Changes since v4:
> - Drop stub removal for !CONFIG_UNICODE case (eric)
> ---
> fs/f2fs/namei.c | 11 +++++------
> fs/f2fs/super.c | 8 ++++----
> 2 files changed, 9 insertions(+), 10 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-05-18 19:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 17:23 [PATCH v5 0/8] Clean up the case-insensitive lookup path Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 17:23 ` [PATCH v5 1/8] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 18:49 ` Eric Biggers
2022-05-18 18:49 ` [f2fs-dev] " Eric Biggers
2022-05-18 17:23 ` [PATCH v5 2/8] f2fs: " Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 18:54 ` Eric Biggers
2022-05-18 18:54 ` [f2fs-dev] " Eric Biggers
2022-05-19 11:27 ` Chao Yu
2022-05-19 11:27 ` Chao Yu
2022-05-19 11:32 ` Chao Yu
2022-05-19 11:32 ` Chao Yu
2022-05-18 17:23 ` [PATCH v5 3/8] libfs: Introduce case-insensitive string comparison helper Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 19:05 ` Eric Biggers
2022-05-18 19:05 ` [f2fs-dev] " Eric Biggers
2022-05-18 17:23 ` [PATCH v5 4/8] ext4: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 19:20 ` Eric Biggers
2022-05-18 19:20 ` [f2fs-dev] " Eric Biggers
2022-05-18 22:44 ` Gabriel Krisman Bertazi
2022-05-18 22:44 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 17:23 ` [PATCH v5 5/8] f2fs: " Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 19:22 ` Eric Biggers
2022-05-18 19:22 ` [f2fs-dev] " Eric Biggers
2022-05-18 17:23 ` [PATCH v5 6/8] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 19:23 ` Eric Biggers
2022-05-18 19:23 ` [f2fs-dev] " Eric Biggers
2022-05-18 17:23 ` [PATCH v5 7/8] ext4: Move CONFIG_UNICODE defguards into the code flow Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 19:25 ` Eric Biggers
2022-05-18 19:25 ` [f2fs-dev] " Eric Biggers
2022-05-18 17:23 ` [PATCH v5 8/8] f2fs: " Gabriel Krisman Bertazi
2022-05-18 17:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-18 19:26 ` Eric Biggers [this message]
2022-05-18 19:26 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoVIfsjT2OE6Wj2k@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.