From: Oliver Upton <oupton@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, maz@kernel.org, bgardon@google.com,
pbonzini@redhat.com, axelrasmussen@google.com,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3 05/13] KVM: selftests: Add missing close and munmap in __vm_mem_region_delete
Date: Thu, 19 May 2022 04:06:19 +0000 [thread overview]
Message-ID: <YoXCOxjjfu4WUuEC@google.com> (raw)
In-Reply-To: <20220408004120.1969099-6-ricarkol@google.com>
On Thu, Apr 07, 2022 at 05:41:12PM -0700, Ricardo Koller wrote:
> Deleting a memslot (when freeing a VM) is not closing the backing fd,
> nor it's unmapping the alias mapping. Fix by adding the missing close
> and munmap.
>
> Reviewed-by: Ben Gardon <bgardon@google.com>
> Signed-off-by: Ricardo Koller <ricarkol@google.com>
Reviewed-by: Oliver Upton <oupton@google.com>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oupton@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
drjones@redhat.com, pbonzini@redhat.com, maz@kernel.org,
alexandru.elisei@arm.com, eric.auger@redhat.com,
reijiw@google.com, rananta@google.com, bgardon@google.com,
axelrasmussen@google.com
Subject: Re: [PATCH v3 05/13] KVM: selftests: Add missing close and munmap in __vm_mem_region_delete
Date: Thu, 19 May 2022 04:06:19 +0000 [thread overview]
Message-ID: <YoXCOxjjfu4WUuEC@google.com> (raw)
In-Reply-To: <20220408004120.1969099-6-ricarkol@google.com>
On Thu, Apr 07, 2022 at 05:41:12PM -0700, Ricardo Koller wrote:
> Deleting a memslot (when freeing a VM) is not closing the backing fd,
> nor it's unmapping the alias mapping. Fix by adding the missing close
> and munmap.
>
> Reviewed-by: Ben Gardon <bgardon@google.com>
> Signed-off-by: Ricardo Koller <ricarkol@google.com>
Reviewed-by: Oliver Upton <oupton@google.com>
next prev parent reply other threads:[~2022-05-19 4:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 0:41 [PATCH v3 00/13] KVM: selftests: Add aarch64/page_fault_test Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-04-08 0:41 ` [PATCH v3 01/13] KVM: selftests: Add a userfaultfd library Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-04-08 0:41 ` [PATCH v3 02/13] KVM: selftests: aarch64: Add vm_get_pte_gpa library function Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-19 3:48 ` Oliver Upton
2022-05-19 3:48 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 03/13] KVM: selftests: Add vm_alloc_page_table_in_memslot " Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-19 3:53 ` Oliver Upton
2022-05-19 3:53 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 04/13] KVM: selftests: aarch64: Export _virt_pg_map with a pt_memslot arg Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-19 4:05 ` Oliver Upton
2022-05-19 4:05 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 05/13] KVM: selftests: Add missing close and munmap in __vm_mem_region_delete Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-19 4:06 ` Oliver Upton [this message]
2022-05-19 4:06 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 06/13] KVM: selftests: Add vm_mem_region_get_src_fd library function Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-19 4:08 ` Oliver Upton
2022-05-19 4:08 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 07/13] KVM: selftests: aarch64: Construct DEFAULT_MAIR_EL1 using sysreg.h macros Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-19 4:17 ` Oliver Upton
2022-05-19 4:17 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 08/13] tools: Copy bitfield.h from the kernel sources Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-19 4:25 ` Oliver Upton
2022-05-19 4:25 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 09/13] KVM: selftests: aarch64: Add aarch64/page_fault_test Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-05-25 19:43 ` Oliver Upton
2022-05-25 19:43 ` Oliver Upton
2022-04-08 0:41 ` [PATCH v3 10/13] KVM: selftests: aarch64: Add userfaultfd tests into page_fault_test Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-04-08 0:41 ` [PATCH v3 11/13] KVM: selftests: aarch64: Add dirty logging " Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-04-08 0:41 ` [PATCH v3 12/13] KVM: selftests: aarch64: Add readonly memslot " Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
2022-04-08 0:41 ` [PATCH v3 13/13] KVM: selftests: aarch64: Add mix of " Ricardo Koller
2022-04-08 0:41 ` Ricardo Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoXCOxjjfu4WUuEC@google.com \
--to=oupton@google.com \
--cc=axelrasmussen@google.com \
--cc=bgardon@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.