All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
Cc: sean.wang@mediatek.com, matthias.bgg@gmail.com,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, nfraprado@collabora.com
Subject: Re: [PATCH v2 2/2] dmaengine: mediatek-cqdma: Add support for MediaTek MT6795
Date: Thu, 19 May 2022 23:31:50 +0530	[thread overview]
Message-ID: <YoaGDjtg0R6NRMmg@matsya> (raw)
In-Reply-To: <20220503140624.117213-3-angelogioacchino.delregno@collabora.com>

On 03-05-22, 16:06, AngeloGioacchino Del Regno wrote:
> Add a compatible string and platform data for the Helio X10 MT6795 SoC.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  drivers/dma/mediatek/mtk-cqdma.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> index a2fb538d9483..e1772dbf50d5 100644
> --- a/drivers/dma/mediatek/mtk-cqdma.c
> +++ b/drivers/dma/mediatek/mtk-cqdma.c
> @@ -757,8 +757,14 @@ static const struct mtk_cqdma_plat_data cqdma_mt6765 = {
>  	.reg_src2 = 0x60,
>  };
>  
> +static const struct mtk_cqdma_plat_data cqdma_mt6795 = {
> +	.reg_dst2 = 0x44,
> +	.reg_src2 = 0x40,

Please define these registers

> +};
> +
>  static const struct of_device_id mtk_cqdma_match[] = {
>  	{ .compatible = "mediatek,mt6765-cqdma", .data = &cqdma_mt6765 },
> +	{ .compatible = "mediatek,mt6795-cqdma", .data = &cqdma_mt6795 },

where is this documented?

>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mtk_cqdma_match);
> -- 
> 2.35.1

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: sean.wang@mediatek.com, matthias.bgg@gmail.com,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, nfraprado@collabora.com
Subject: Re: [PATCH v2 2/2] dmaengine: mediatek-cqdma: Add support for MediaTek MT6795
Date: Thu, 19 May 2022 23:31:50 +0530	[thread overview]
Message-ID: <YoaGDjtg0R6NRMmg@matsya> (raw)
In-Reply-To: <20220503140624.117213-3-angelogioacchino.delregno@collabora.com>

On 03-05-22, 16:06, AngeloGioacchino Del Regno wrote:
> Add a compatible string and platform data for the Helio X10 MT6795 SoC.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  drivers/dma/mediatek/mtk-cqdma.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> index a2fb538d9483..e1772dbf50d5 100644
> --- a/drivers/dma/mediatek/mtk-cqdma.c
> +++ b/drivers/dma/mediatek/mtk-cqdma.c
> @@ -757,8 +757,14 @@ static const struct mtk_cqdma_plat_data cqdma_mt6765 = {
>  	.reg_src2 = 0x60,
>  };
>  
> +static const struct mtk_cqdma_plat_data cqdma_mt6795 = {
> +	.reg_dst2 = 0x44,
> +	.reg_src2 = 0x40,

Please define these registers

> +};
> +
>  static const struct of_device_id mtk_cqdma_match[] = {
>  	{ .compatible = "mediatek,mt6765-cqdma", .data = &cqdma_mt6765 },
> +	{ .compatible = "mediatek,mt6795-cqdma", .data = &cqdma_mt6795 },

where is this documented?

>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mtk_cqdma_match);
> -- 
> 2.35.1

-- 
~Vinod

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: sean.wang@mediatek.com, matthias.bgg@gmail.com,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, nfraprado@collabora.com
Subject: Re: [PATCH v2 2/2] dmaengine: mediatek-cqdma: Add support for MediaTek MT6795
Date: Thu, 19 May 2022 23:31:50 +0530	[thread overview]
Message-ID: <YoaGDjtg0R6NRMmg@matsya> (raw)
In-Reply-To: <20220503140624.117213-3-angelogioacchino.delregno@collabora.com>

On 03-05-22, 16:06, AngeloGioacchino Del Regno wrote:
> Add a compatible string and platform data for the Helio X10 MT6795 SoC.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  drivers/dma/mediatek/mtk-cqdma.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> index a2fb538d9483..e1772dbf50d5 100644
> --- a/drivers/dma/mediatek/mtk-cqdma.c
> +++ b/drivers/dma/mediatek/mtk-cqdma.c
> @@ -757,8 +757,14 @@ static const struct mtk_cqdma_plat_data cqdma_mt6765 = {
>  	.reg_src2 = 0x60,
>  };
>  
> +static const struct mtk_cqdma_plat_data cqdma_mt6795 = {
> +	.reg_dst2 = 0x44,
> +	.reg_src2 = 0x40,

Please define these registers

> +};
> +
>  static const struct of_device_id mtk_cqdma_match[] = {
>  	{ .compatible = "mediatek,mt6765-cqdma", .data = &cqdma_mt6765 },
> +	{ .compatible = "mediatek,mt6795-cqdma", .data = &cqdma_mt6795 },

where is this documented?

>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mtk_cqdma_match);
> -- 
> 2.35.1

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-19 18:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 14:06 [PATCH v2 0/2] MediaTek Helio X10 MT6795 - CQDMA driver AngeloGioacchino Del Regno
2022-05-03 14:06 ` AngeloGioacchino Del Regno
2022-05-03 14:06 ` AngeloGioacchino Del Regno
2022-05-03 14:06 ` [PATCH v2 1/2] dmaengine: mediatek-cqdma: Add SoC-specific match data AngeloGioacchino Del Regno
2022-05-03 14:06   ` AngeloGioacchino Del Regno
2022-05-03 14:06   ` AngeloGioacchino Del Regno
2022-05-19 18:00   ` Vinod Koul
2022-05-19 18:00     ` Vinod Koul
2022-05-19 18:00     ` Vinod Koul
2022-05-03 14:06 ` [PATCH v2 2/2] dmaengine: mediatek-cqdma: Add support for MediaTek MT6795 AngeloGioacchino Del Regno
2022-05-03 14:06   ` AngeloGioacchino Del Regno
2022-05-03 14:06   ` AngeloGioacchino Del Regno
2022-05-19 18:01   ` Vinod Koul [this message]
2022-05-19 18:01     ` Vinod Koul
2022-05-19 18:01     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoaGDjtg0R6NRMmg@matsya \
    --to=vkoul@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.