From: Al Viro <viro@zeniv.linux.org.uk>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char/mem: only use {read,write}_iter, not the old {read,write} functions
Date: Fri, 20 May 2022 15:44:04 +0000 [thread overview]
Message-ID: <Yoe3ROmrA8sNe3Cb@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <f3878dfd-67f7-9a01-8dcf-7202bf5f3918@kernel.dk>
On Fri, May 20, 2022 at 09:32:34AM -0600, Jens Axboe wrote:
> Didn't look closer, but I'm assuming this is _mostly_ tied to needing to
> init 48 bytes of kiocb for each one. There might be ways to embed a
> sync_kiocb inside the kiocb for the bits we need there, at least that
> could get us down to 32 bytes.
My bet would be on iocb_flags() (and kiocb_set_rw_flags()) tests and
pointer-chasing, actually. I'd been sick on and off since early November,
trying to dig myself from under the piles right now. Christoph's
patches in that area are somewhere in the pile ;-/
next prev parent reply other threads:[~2022-05-20 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 13:50 [PATCH] char/mem: only use {read,write}_iter, not the old {read,write} functions Jason A. Donenfeld
2022-05-20 14:38 ` Jens Axboe
2022-05-20 15:09 ` Al Viro
2022-05-20 15:11 ` Jens Axboe
2022-05-20 15:32 ` Jens Axboe
2022-05-20 15:44 ` Al Viro [this message]
2022-05-20 15:46 ` Jens Axboe
2022-05-21 17:51 ` Al Viro
2022-05-20 15:24 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yoe3ROmrA8sNe3Cb@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Jason@zx2c4.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.