From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] char/mem: only use {read,write}_iter, not the old {read,write} functions
Date: Fri, 20 May 2022 17:24:07 +0200 [thread overview]
Message-ID: <Yoeylxfbl9hDI/jE@zx2c4.com> (raw)
In-Reply-To: <YoevH5YFLcBBfsB0@zeniv-ca.linux.org.uk>
Hi Al,
On Fri, May 20, 2022 at 03:09:19PM +0000, Al Viro wrote:
> On Fri, May 20, 2022 at 03:50:30PM +0200, Jason A. Donenfeld wrote:
> > Currently mem.c implements both the {read,write}_iter functions and the
> > {read,write} functions. But with {read,write} going away at some point
> > in the future,
>
> Not likely to happen, unfortunately.
>
> > and most kernel code made to prefer {read,write}_iter,
> > there's no point in keeping around the old code.
>
> Profile and you'll see ;-/
Huh, yea, I lose around 1 GiB/s of perf on my machine sending /dev/zero
into /dev/null.
Jason
prev parent reply other threads:[~2022-05-20 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 13:50 [PATCH] char/mem: only use {read,write}_iter, not the old {read,write} functions Jason A. Donenfeld
2022-05-20 14:38 ` Jens Axboe
2022-05-20 15:09 ` Al Viro
2022-05-20 15:11 ` Jens Axboe
2022-05-20 15:32 ` Jens Axboe
2022-05-20 15:44 ` Al Viro
2022-05-20 15:46 ` Jens Axboe
2022-05-21 17:51 ` Al Viro
2022-05-20 15:24 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yoeylxfbl9hDI/jE@zx2c4.com \
--to=jason@zx2c4.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.