From: Patrick Steinhardt <ps@pks.im>
To: Glenn Washburn <development@efficientek.com>
Cc: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>,
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>,
John Lane <john@lane.uk.net>
Subject: Re: [PATCH v2 0/3] Cryptomount detached headers
Date: Sun, 29 May 2022 08:48:41 +0200 [thread overview]
Message-ID: <YpMXSSxzHBPJIMw7@xps> (raw)
In-Reply-To: <cover.1652736873.git.development@efficientek.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote:
> Note: Description here has changed since last time, the last few sentences,
> which describe a method for allowing backends to bypass the read hook on
> the source disk.
>
> Updates since v1:
> * Add marge comment block describing at a high level the read hook operation
> and assumptions.
> * Add code to unset read hook on source disk when exiting
> grub_cryptodisk_scan_device_real(). A couple return calls were converted
> into gotos so that logical flows to one exit point.
[snip]
I've reviewed this patch series, and except for a single nit the changes
all look good to me. So please feel free to add my
Reviewed-by: Patrick Steinhardt <ps@pks.im>
, regardless of whether you decide to apply my prosed nit in 2/3 or not.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-05-29 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 21:49 [PATCH v2 0/3] Cryptomount detached headers Glenn Washburn
2022-05-16 21:49 ` [PATCH v2 1/3] disk: Allow read hook callback to take read buffer to potentially modify it Glenn Washburn
2022-05-16 21:49 ` [PATCH v2 2/3] cryptodisk: Add support for using detached header files Glenn Washburn
2022-05-29 6:45 ` Patrick Steinhardt
2022-06-05 18:47 ` Glenn Washburn
2022-05-16 21:49 ` [PATCH v2 3/3] docs: Add documentation on detached header option to cryptomount Glenn Washburn
2022-05-27 14:06 ` [PATCH v2 0/3] Cryptomount detached headers Daniel Kiper
2022-05-27 20:20 ` Glenn Washburn
2022-05-27 21:38 ` Daniel Kiper
2022-05-29 6:48 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpMXSSxzHBPJIMw7@xps \
--to=ps@pks.im \
--cc=GNUtoo@cyberdimension.org \
--cc=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=john@lane.uk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.