All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-input@vger.kernel.org, Hugh Dickins <hughd@google.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: Suspend/Resume (S3) issues with rmi_smbus
Date: Tue, 31 May 2022 08:50:57 -0700	[thread overview]
Message-ID: <YpY5YU+KTg/Dmaex@google.com> (raw)
In-Reply-To: <YpXXu2tbCSCUtUYQ@worktop.programming.kicks-ass.net>

On Tue, May 31, 2022 at 10:54:19AM +0200, Peter Zijlstra wrote:
> On Mon, May 30, 2022 at 12:15:40PM -0700, Dmitry Torokhov wrote:
> 
> > Can you check the entire list of resume operations to make sure that
> > PS/2 device is resumed before RMI one?
> 
> It reports psmouse failure *after* the rmi4 failure. Is there a knob to
> make it print more device model details on resume?
> 
> > You can also try overriding devices driven by rmi_smbus as needing
> > synchronous resume (see
> > https://lore.kernel.org/all/YgHTYrODoo2ou49J@google.com/).
> 
> I can confirm this works.

Let's ask Rafael if he has an idea why adding a link between PS/2 device
and its SMbus companion did not seem to affect resume order. Was there a
change in 5.18 timeframe (since original reporters said that adding
device link helped their case).

Let's also add a couple of more folks who experienced original issue to
see if they observe this as well.

Thanks.

-- 
Dmitry

  reply	other threads:[~2022-05-31 15:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-30  8:48 Suspend/Resume (S3) issues with rmi_smbus Peter Zijlstra
2022-05-30 19:15 ` Dmitry Torokhov
2022-05-31  8:54   ` Peter Zijlstra
2022-05-31 15:50     ` Dmitry Torokhov [this message]
2022-06-01 12:47       ` Jarkko Nikula
2022-06-01 17:02         ` Hugh Dickins
2022-06-01  6:40     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpY5YU+KTg/Dmaex@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=hughd@google.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.