All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	david@fromorbit.com, Matthew Wilcox <willy@infradead.org>
Subject: Re: [dm-devel] bioset_exit poison from dm_destroy
Date: Tue, 31 May 2022 23:04:49 -0700	[thread overview]
Message-ID: <YpcBgY9MMgumEjTL@infradead.org> (raw)
In-Reply-To: <YpZlOCMept7wFjOw@redhat.com>

On Tue, May 31, 2022 at 02:58:00PM -0400, Mike Snitzer wrote:
> Yes, we need the above to fix the crash.  Does it also make sense to
> add this?

Can we just stop treating bio_sets so sloppily and make the callers
handle their lifetime properly?  No one should have to use
bioset_initialized (or double free bio_sets).

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Matthew Wilcox <willy@infradead.org>,
	dm-devel@redhat.com, linux-block@vger.kernel.org,
	david@fromorbit.com
Subject: Re: bioset_exit poison from dm_destroy
Date: Tue, 31 May 2022 23:04:49 -0700	[thread overview]
Message-ID: <YpcBgY9MMgumEjTL@infradead.org> (raw)
In-Reply-To: <YpZlOCMept7wFjOw@redhat.com>

On Tue, May 31, 2022 at 02:58:00PM -0400, Mike Snitzer wrote:
> Yes, we need the above to fix the crash.  Does it also make sense to
> add this?

Can we just stop treating bio_sets so sloppily and make the callers
handle their lifetime properly?  No one should have to use
bioset_initialized (or double free bio_sets).


  parent reply	other threads:[~2022-06-01  6:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-29  0:17 [dm-devel] bioset_exit poison from dm_destroy Matthew Wilcox
2022-05-29  0:17 ` Matthew Wilcox
2022-05-29 12:46 ` [dm-devel] " Jens Axboe
2022-05-29 12:46   ` Jens Axboe
2022-05-31 18:58   ` [dm-devel] " Mike Snitzer
2022-05-31 18:58     ` Mike Snitzer
2022-05-31 19:00     ` [dm-devel] " Jens Axboe
2022-05-31 19:00       ` Jens Axboe
2022-05-31 19:49       ` [dm-devel] " Mike Snitzer
2022-05-31 19:49         ` Mike Snitzer
2022-06-01  3:27         ` [dm-devel] " Jens Axboe
2022-06-01  3:27           ` Jens Axboe
2022-06-01  6:04     ` Christoph Hellwig [this message]
2022-06-01  6:04       ` Christoph Hellwig
2022-06-01  6:08       ` [dm-devel] " Jens Axboe
2022-06-01  6:08         ` Jens Axboe
2022-06-01  6:18         ` [dm-devel] " Christoph Hellwig
2022-06-01  6:18           ` Christoph Hellwig
2022-06-01 14:13       ` [dm-devel] " Mike Snitzer
2022-06-01 14:13         ` Mike Snitzer
2022-06-02  8:12         ` [dm-devel] " Christoph Hellwig
2022-06-02  8:12           ` Christoph Hellwig
2022-06-02  8:18           ` [dm-devel] " Jens Axboe
2022-06-02  8:18             ` Jens Axboe
2022-06-03 13:09           ` [dm-devel] " Mike Snitzer
2022-06-03 13:09             ` Mike Snitzer
2022-06-03 13:19             ` [dm-devel] " Christoph Hellwig
2022-06-03 13:19               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpcBgY9MMgumEjTL@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=david@fromorbit.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.