From: Mark Brown <broonie@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] arm64/sme: Fix the ffr variable assignment
Date: Thu, 2 Jun 2022 10:26:31 +0200 [thread overview]
Message-ID: <Yph0Nxy+++lskDOb@sirena.org.uk> (raw)
In-Reply-To: <20220601171346.2143699-1-catalin.marinas@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 833 bytes --]
On Wed, Jun 01, 2022 at 06:13:46PM +0100, Catalin Marinas wrote:
> This variable is a bool and expected to be set to true if the FFR
> state needs saving/restoring, false otherwise. In __efi_fpsimd_end()
> this variable should be restored to the value of efi_sm_state but this
> is a per-CPU variable, not to be read directly. Make ffr false if
> !__this_cpu_read(efi_sm_state), leave it true otherwise.
> - if (__this_cpu_read(efi_sm_state)) {
> + if (__this_cpu_read(efi_sm_state))
> sysreg_clear_set_s(SYS_SVCR,
> 0,
> SVCR_SM_MASK);
> - if (!system_supports_fa64())
> - ffr = efi_sm_state;
> - }
> + else
> + ffr = false;
In the case where we support FA64 we need to load FFR so this
needs to be conditional on system_supports_fa64() in the case
where efi_sm_state is true.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-02 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 17:13 [PATCH] arm64/sme: Fix the ffr variable assignment Catalin Marinas
2022-06-02 8:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yph0Nxy+++lskDOb@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.