From: Andrew Lunn <andrew@lunn.ch>
To: Puranjay Mohan <p-mohan@ti.com>
Cc: nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com,
vigneshr@ti.com, edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kishon@ti.com, rogerq@kernel.org,
afd@ti.com, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
ssantosh@kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings
Date: Sun, 5 Jun 2022 17:11:02 +0200 [thread overview]
Message-ID: <YpzHhsPlbKLecUdO@lunn.ch> (raw)
In-Reply-To: <faff79c9-7e1e-a69b-f314-6c00dedf1722@ti.com>
> He said ethernet-port is preferred but all other drivers were using
> "port" so I though it is not compulsory. Will change it if it compulsory
> to use ethernet-port
It is a good idea to mention this in the change history. It is then
clear you have considered it, but decided against it.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Puranjay Mohan <p-mohan@ti.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, krzysztof.kozlowski+dt@linaro.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org, nm@ti.com,
ssantosh@kernel.org, s-anna@ti.com,
linux-arm-kernel@lists.infradead.org, rogerq@kernel.org,
grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com,
robh+dt@kernel.org, afd@ti.com
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings
Date: Sun, 5 Jun 2022 17:11:02 +0200 [thread overview]
Message-ID: <YpzHhsPlbKLecUdO@lunn.ch> (raw)
In-Reply-To: <faff79c9-7e1e-a69b-f314-6c00dedf1722@ti.com>
> He said ethernet-port is preferred but all other drivers were using
> "port" so I though it is not compulsory. Will change it if it compulsory
> to use ethernet-port
It is a good idea to mention this in the change history. It is then
clear you have considered it, but decided against it.
Andrew
next prev parent reply other threads:[~2022-06-05 15:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 9:51 [PATCH v2 0/2] Introduce ICSSG based ethernet Driver Puranjay Mohan
2022-05-31 9:51 ` Puranjay Mohan
2022-05-31 9:51 ` [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Puranjay Mohan
2022-05-31 9:51 ` Puranjay Mohan
2022-05-31 10:08 ` Krzysztof Kozlowski
2022-05-31 10:08 ` Krzysztof Kozlowski
2022-05-31 11:27 ` Puranjay Mohan
2022-05-31 11:27 ` Puranjay Mohan
2022-05-31 11:48 ` Krzysztof Kozlowski
2022-05-31 11:48 ` Krzysztof Kozlowski
2022-05-31 11:59 ` Puranjay Mohan
2022-05-31 11:59 ` Puranjay Mohan
2022-05-31 12:01 ` Krzysztof Kozlowski
2022-05-31 12:01 ` Krzysztof Kozlowski
2022-06-01 4:28 ` Puranjay Mohan
2022-06-01 4:28 ` Puranjay Mohan
2022-06-05 15:11 ` Andrew Lunn [this message]
2022-06-05 15:11 ` Andrew Lunn
2022-11-04 7:28 ` Md Danish Anwar
2022-11-04 7:28 ` Md Danish Anwar
2022-11-04 12:57 ` Krzysztof Kozlowski
2022-11-04 12:57 ` Krzysztof Kozlowski
2022-05-31 13:21 ` Rob Herring
2022-05-31 13:21 ` Rob Herring
2022-05-31 9:51 ` [PATCH v2 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver Puranjay Mohan
2022-05-31 10:20 ` Krzysztof Kozlowski
2022-05-31 10:20 ` Krzysztof Kozlowski
2022-05-31 11:23 ` Paolo Abeni
2022-05-31 11:23 ` Paolo Abeni
2022-11-04 8:29 ` Md Danish Anwar
2022-11-04 8:29 ` Md Danish Anwar
2022-05-31 13:11 ` Randy Dunlap
2022-05-31 13:11 ` Randy Dunlap
2022-06-05 15:37 ` Andrew Lunn
2022-06-05 15:37 ` Andrew Lunn
2022-11-04 10:26 ` Md Danish Anwar
2022-11-04 10:26 ` Md Danish Anwar
2022-06-05 16:24 ` Christophe JAILLET
2022-06-05 16:24 ` Christophe JAILLET
2022-11-04 9:50 ` Md Danish Anwar
2022-11-04 9:50 ` Md Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpzHhsPlbKLecUdO@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=p-mohan@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.