* Re: gitlab: convert Cirrus jobs to .base_job_template
@ 2022-06-08 15:48 Richard Henderson
2022-06-08 16:07 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2022-06-08 15:48 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: qemu-devel
Commit 00125414ba1 is not working as intended. E.g.
https://gitlab.com/rth7680/qemu/-/jobs/2558862885
where I have neither CIRRUS_GITHUB_REPO nor CIRRUS_API_TOKEN set, but the job tries to run
anyway. Then fails, predictably, with "token not defined".
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gitlab: convert Cirrus jobs to .base_job_template
2022-06-08 15:48 gitlab: convert Cirrus jobs to .base_job_template Richard Henderson
@ 2022-06-08 16:07 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2022-06-08 16:07 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel
On Wed, Jun 08, 2022 at 08:48:48AM -0700, Richard Henderson wrote:
> Commit 00125414ba1 is not working as intended. E.g.
>
> https://gitlab.com/rth7680/qemu/-/jobs/2558862885
>
> where I have neither CIRRUS_GITHUB_REPO nor CIRRUS_API_TOKEN set, but the
> job tries to run anyway. Then fails, predictably, with "token not defined".
Opps, GitLab variable comparisons aren't shell-like where an unset
variable compares equal to empty string.
I just sent a fix & CC'd you
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-08 16:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-08 15:48 gitlab: convert Cirrus jobs to .base_job_template Richard Henderson
2022-06-08 16:07 ` Daniel P. Berrangé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.