All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] fix and cleanup device mapper bioset initialization
Date: Wed, 8 Jun 2022 14:16:26 -0400	[thread overview]
Message-ID: <YqDneqyp33PvkCLm@redhat.com> (raw)
In-Reply-To: <20220608063409.1280968-1-hch@lst.de>

On Wed, Jun 08 2022 at  2:34P -0400,
Christoph Hellwig <hch@lst.de> wrote:

> Hi Mike,
> 
> the first patch fixes the device mapper bioset to restore the previous
> behavior of preallocating biosets instead of allocating them at bind
> time, and to actually allocate pools for the integrity data.  The
> others are cleanups on top of that.
> 
> Diffstat:
>  block/bio.c           |   20 -------
>  drivers/md/dm-core.h  |   14 ++++-
>  drivers/md/dm-rq.c    |    3 -
>  drivers/md/dm-table.c |   66 ++++++++++++++----------
>  drivers/md/dm.c       |  136 +++++++++-----------------------------------------
>  drivers/md/dm.h       |    5 -
>  include/linux/bio.h   |    1 
>  7 files changed, 78 insertions(+), 167 deletions(-)
> 

All looks good to me.  Are you OK with me picking up the first 3 to
send to Linus for 5.19-rc2 (given the integrity bioset fix)?

And hold patch 4 until 5.20 merge?  Or would you prefer that cleanup
to land now too?

Mike

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: fix and cleanup device mapper bioset initialization
Date: Wed, 8 Jun 2022 14:16:26 -0400	[thread overview]
Message-ID: <YqDneqyp33PvkCLm@redhat.com> (raw)
In-Reply-To: <20220608063409.1280968-1-hch@lst.de>

On Wed, Jun 08 2022 at  2:34P -0400,
Christoph Hellwig <hch@lst.de> wrote:

> Hi Mike,
> 
> the first patch fixes the device mapper bioset to restore the previous
> behavior of preallocating biosets instead of allocating them at bind
> time, and to actually allocate pools for the integrity data.  The
> others are cleanups on top of that.
> 
> Diffstat:
>  block/bio.c           |   20 -------
>  drivers/md/dm-core.h  |   14 ++++-
>  drivers/md/dm-rq.c    |    3 -
>  drivers/md/dm-table.c |   66 ++++++++++++++----------
>  drivers/md/dm.c       |  136 +++++++++-----------------------------------------
>  drivers/md/dm.h       |    5 -
>  include/linux/bio.h   |    1 
>  7 files changed, 78 insertions(+), 167 deletions(-)
> 

All looks good to me.  Are you OK with me picking up the first 3 to
send to Linus for 5.19-rc2 (given the integrity bioset fix)?

And hold patch 4 until 5.20 merge?  Or would you prefer that cleanup
to land now too?

Mike

  parent reply	other threads:[~2022-06-08 18:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08  6:34 [dm-devel] fix and cleanup device mapper bioset initialization Christoph Hellwig
2022-06-08  6:34 ` Christoph Hellwig
2022-06-08  6:34 ` [dm-devel] [PATCH 1/4] dm: fix bio_set allocation Christoph Hellwig
2022-06-08  6:34   ` Christoph Hellwig
2022-06-08  6:34 ` [dm-devel] [PATCH 2/4] block: remove bioset_init_from_src Christoph Hellwig
2022-06-08  6:34   ` Christoph Hellwig
2022-06-08  6:34 ` [dm-devel] [PATCH 3/4] dm: unexport dm_get_reserved_rq_based_ios Christoph Hellwig
2022-06-08  6:34   ` Christoph Hellwig
2022-06-08  6:34 ` [dm-devel] [PATCH 4/4] dm: refactor dm_md_mempool allocation Christoph Hellwig
2022-06-08  6:34   ` Christoph Hellwig
2022-06-08 18:16 ` Mike Snitzer [this message]
2022-06-08 18:16   ` fix and cleanup device mapper bioset initialization Mike Snitzer
2022-06-09  4:11   ` [dm-devel] " Christoph Hellwig
2022-06-09  4:11     ` Christoph Hellwig
2022-06-09 18:16     ` [dm-devel] " Mike Snitzer
2022-06-09 18:16       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqDneqyp33PvkCLm@redhat.com \
    --to=snitzer@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.