From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] mfd: t7l66xb: Drop platform disable callback
Date: Wed, 15 Jun 2022 22:06:43 +0100 [thread overview]
Message-ID: <YqpJ49i4yEFdGznZ@google.com> (raw)
In-Reply-To: <20220530192430.2108217-3-u.kleine-koenig@pengutronix.de>
On Mon, 30 May 2022, Uwe Kleine-König wrote:
> None of the in-tree instantiations of struct t7l66xb_platform_data
> provides a disable callback. So better don't dereference this function
> pointer unconditionally. As there is no user, drop it completely instead
> of calling it conditional.
>
> This is a preparation for making platform remove callbacks return void.
>
> Fixes: 1f192015ca5b ("mfd: driver for the T7L66XB TMIO SoC")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Technically this fixes the first commit introducing a struct
> t7l66xb_platform_data without a disable callback, but ...
> ---
> drivers/mfd/t7l66xb.c | 6 +-----
> include/linux/mfd/t7l66xb.h | 1 -
> 2 files changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] mfd: t7l66xb: Drop platform disable callback
Date: Wed, 15 Jun 2022 22:06:43 +0100 [thread overview]
Message-ID: <YqpJ49i4yEFdGznZ@google.com> (raw)
In-Reply-To: <20220530192430.2108217-3-u.kleine-koenig@pengutronix.de>
On Mon, 30 May 2022, Uwe Kleine-König wrote:
> None of the in-tree instantiations of struct t7l66xb_platform_data
> provides a disable callback. So better don't dereference this function
> pointer unconditionally. As there is no user, drop it completely instead
> of calling it conditional.
>
> This is a preparation for making platform remove callbacks return void.
>
> Fixes: 1f192015ca5b ("mfd: driver for the T7L66XB TMIO SoC")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Technically this fixes the first commit introducing a struct
> t7l66xb_platform_data without a disable callback, but ...
> ---
> drivers/mfd/t7l66xb.c | 6 +-----
> include/linux/mfd/t7l66xb.h | 1 -
> 2 files changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-06-15 21:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 19:24 [PATCH 0/4] mfd: Some preparations for making platform remove callbacks return void Uwe Kleine-König
2022-05-30 19:24 ` Uwe Kleine-König
2022-05-30 19:24 ` [PATCH 1/4] mfd: asic3: Make asic3_gpio_remove() " Uwe Kleine-König
2022-06-15 21:06 ` Lee Jones
2022-05-30 19:24 ` [PATCH 2/4] mfd: t7l66xb: Drop platform disable callback Uwe Kleine-König
2022-05-30 19:24 ` Uwe Kleine-König
2022-06-15 21:06 ` Lee Jones [this message]
2022-06-15 21:06 ` Lee Jones
2022-05-30 19:24 ` [PATCH 3/4] mfd: tc6387xb: Drop disable callback that is never called Uwe Kleine-König
2022-05-30 19:24 ` Uwe Kleine-König
2022-06-15 21:07 ` Lee Jones
2022-06-15 21:07 ` Lee Jones
2022-06-19 8:32 ` Uwe Kleine-König
2022-06-19 8:32 ` Uwe Kleine-König
2022-06-20 8:31 ` Lee Jones
2022-06-20 8:31 ` Lee Jones
2022-05-30 19:24 ` [PATCH 4/4] mfd: tc6393xb: Make disable callback return void Uwe Kleine-König
2022-05-30 19:24 ` Uwe Kleine-König
2022-06-15 21:08 ` Lee Jones
2022-06-15 21:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqpJ49i4yEFdGznZ@google.com \
--to=lee.jones@linaro.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.