From: Vinod Koul <vkoul@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Martin Povišer" <povik+lin@cutebit.org>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: apple-admac: Use {low,upp}er_32_bits() to split 64-bit address
Date: Thu, 16 Jun 2022 07:17:05 -0700 [thread overview]
Message-ID: <Yqs7YSR12L42zFL5@matsya> (raw)
In-Reply-To: <20220616141312.1953819-1-geert@linux-m68k.org>
On 16-06-22, 16:13, Geert Uytterhoeven wrote:
> If CONFIG_PHYS_ADDR_T_64BIT is not set:
>
> drivers/dma/apple-admac.c: In function ‘admac_cyclic_write_one_desc’:
> drivers/dma/apple-admac.c:213:22: error: right shift count >= width of type [-Werror=shift-count-overflow]
> 213 | writel_relaxed(addr >> 32, ad->base + REG_DESC_WRITE(channo));
> | ^~
>
> Fix this by using the {low,upp}er_32_bits() helper macros to obtain the
> address parts.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Martin Povišer" <povik+lin@cutebit.org>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: apple-admac: Use {low,upp}er_32_bits() to split 64-bit address
Date: Thu, 16 Jun 2022 07:17:05 -0700 [thread overview]
Message-ID: <Yqs7YSR12L42zFL5@matsya> (raw)
In-Reply-To: <20220616141312.1953819-1-geert@linux-m68k.org>
On 16-06-22, 16:13, Geert Uytterhoeven wrote:
> If CONFIG_PHYS_ADDR_T_64BIT is not set:
>
> drivers/dma/apple-admac.c: In function ‘admac_cyclic_write_one_desc’:
> drivers/dma/apple-admac.c:213:22: error: right shift count >= width of type [-Werror=shift-count-overflow]
> 213 | writel_relaxed(addr >> 32, ad->base + REG_DESC_WRITE(channo));
> | ^~
>
> Fix this by using the {low,upp}er_32_bits() helper macros to obtain the
> address parts.
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-16 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 14:13 [PATCH v2] dmaengine: apple-admac: Use {low,upp}er_32_bits() to split 64-bit address Geert Uytterhoeven
2022-06-16 14:13 ` Geert Uytterhoeven
2022-06-16 14:17 ` Vinod Koul [this message]
2022-06-16 14:17 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqs7YSR12L42zFL5@matsya \
--to=vkoul@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=povik+lin@cutebit.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.