All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Will Deacon <will@kernel.org>,
	Peter Collingbourne <pcc@google.com>,
	kasan-dev@googlegroups.com, linux-mm@kvack.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] mm: kasan: Skip unpoisoning of user pages
Date: Thu, 16 Jun 2022 18:40:40 +0100	[thread overview]
Message-ID: <YqtrGLhheCpkBI09@arm.com> (raw)
In-Reply-To: <75aa779d-785f-6515-51cd-654e8c5d18f5@arm.com>

On Thu, Jun 16, 2022 at 09:42:10AM +0100, Vincenzo Frascino wrote:
> On 6/10/22 16:21, Catalin Marinas wrote:
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index e008a3df0485..f6ed240870bc 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -2397,6 +2397,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order,
> >  	bool init = !want_init_on_free() && want_init_on_alloc(gfp_flags) &&
> >  			!should_skip_init(gfp_flags);
> >  	bool init_tags = init && (gfp_flags & __GFP_ZEROTAGS);
> > +	int i;
> >  
> 
> Nit: Since "i" is not used outside of the for loop context we could use the
> contract form "for (int i = 0; ..." which is allowed by C11.

Oh yeah, Linux moved to C11 in 5.18. But it looks better to be
consistent with the other for loop in this file.

> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Will Deacon <will@kernel.org>,
	Peter Collingbourne <pcc@google.com>,
	kasan-dev@googlegroups.com, linux-mm@kvack.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] mm: kasan: Skip unpoisoning of user pages
Date: Thu, 16 Jun 2022 18:40:40 +0100	[thread overview]
Message-ID: <YqtrGLhheCpkBI09@arm.com> (raw)
In-Reply-To: <75aa779d-785f-6515-51cd-654e8c5d18f5@arm.com>

On Thu, Jun 16, 2022 at 09:42:10AM +0100, Vincenzo Frascino wrote:
> On 6/10/22 16:21, Catalin Marinas wrote:
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index e008a3df0485..f6ed240870bc 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -2397,6 +2397,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order,
> >  	bool init = !want_init_on_free() && want_init_on_alloc(gfp_flags) &&
> >  			!should_skip_init(gfp_flags);
> >  	bool init_tags = init && (gfp_flags & __GFP_ZEROTAGS);
> > +	int i;
> >  
> 
> Nit: Since "i" is not used outside of the for loop context we could use the
> contract form "for (int i = 0; ..." which is allowed by C11.

Oh yeah, Linux moved to C11 in 5.18. But it looks better to be
consistent with the other for loop in this file.

> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

Thanks.

-- 
Catalin


  reply	other threads:[~2022-06-16 17:41 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 15:21 [PATCH v2 0/4] kasan: Fix ordering between MTE tag colouring and page->flags Catalin Marinas
2022-06-10 15:21 ` Catalin Marinas
2022-06-10 15:21 ` [PATCH v2 1/4] mm: kasan: Ensure the tags are visible before the tag in page->flags Catalin Marinas
2022-06-10 15:21   ` Catalin Marinas
2022-06-16  8:31   ` Vincenzo Frascino
2022-06-16  8:31     ` Vincenzo Frascino
2022-07-07  9:22   ` Will Deacon
2022-07-07  9:22     ` Will Deacon
2022-07-07 11:44     ` Catalin Marinas
2022-07-07 11:44       ` Catalin Marinas
2022-06-10 15:21 ` [PATCH v2 2/4] mm: kasan: Skip unpoisoning of user pages Catalin Marinas
2022-06-10 15:21   ` Catalin Marinas
2022-06-11 19:40   ` Andrey Konovalov
2022-06-11 19:40     ` Andrey Konovalov
2022-06-16  8:42   ` Vincenzo Frascino
2022-06-16  8:42     ` Vincenzo Frascino
2022-06-16 17:40     ` Catalin Marinas [this message]
2022-06-16 17:40       ` Catalin Marinas
2022-06-10 15:21 ` [PATCH v2 3/4] mm: kasan: Skip page unpoisoning only if __GFP_SKIP_KASAN_UNPOISON Catalin Marinas
2022-06-10 15:21   ` Catalin Marinas
2022-06-11 19:40   ` Andrey Konovalov
2022-06-11 19:40     ` Andrey Konovalov
2022-06-16  8:43   ` Vincenzo Frascino
2022-06-16  8:43     ` Vincenzo Frascino
2022-06-10 15:21 ` [PATCH v2 4/4] arm64: kasan: Revert "arm64: mte: reset the page tag in page->flags" Catalin Marinas
2022-06-10 15:21   ` Catalin Marinas
2022-06-11 19:40   ` Andrey Konovalov
2022-06-11 19:40     ` Andrey Konovalov
2022-06-16  8:44   ` Vincenzo Frascino
2022-06-16  8:44     ` Vincenzo Frascino
2022-07-07 10:33 ` [PATCH v2 0/4] kasan: Fix ordering between MTE tag colouring and page->flags Will Deacon
2022-07-07 10:33   ` Will Deacon
2022-07-08 13:31 ` Will Deacon
2022-07-08 13:31   ` Will Deacon
2023-02-02  5:25 ` Kuan-Ying Lee (李冠穎)
2023-02-02  5:25   ` Kuan-Ying Lee (李冠穎)
2023-02-02 12:59   ` Andrey Konovalov
2023-02-02 12:59     ` Andrey Konovalov
2023-02-03  3:41     ` Kuan-Ying Lee (李冠穎)
2023-02-03  3:41       ` Kuan-Ying Lee (李冠穎)
2023-02-03 17:51       ` Andrey Konovalov
2023-02-03 17:51         ` Andrey Konovalov
2023-02-08  5:41         ` Qun-wei Lin (林群崴)
2023-02-08  5:41           ` Qun-wei Lin (林群崴)
2023-02-10  6:19           ` Peter Collingbourne
2023-02-10  6:19             ` Peter Collingbourne
2023-02-10 18:28             ` Catalin Marinas
2023-02-10 18:28               ` Catalin Marinas
2023-02-10 19:03               ` Peter Collingbourne
2023-02-10 19:03                 ` Peter Collingbourne
2023-02-13 18:47                 ` Catalin Marinas
2023-02-13 18:47                   ` Catalin Marinas
2023-02-14  1:56                   ` Peter Collingbourne
2023-02-14  1:56                     ` Peter Collingbourne
2023-02-13  1:56             ` Qun-wei Lin (林群崴)
2023-02-13  1:56               ` Qun-wei Lin (林群崴)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqtrGLhheCpkBI09@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=andreyknvl@gmail.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=pcc@google.com \
    --cc=ryabinin.a.a@gmail.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.